🧹 Bolt: Replace assert statements with BNGSimulatorError in csimulator - #57
🧹 Bolt: Replace assert statements with BNGSimulatorError in csimulator#57akutuva21 wants to merge 3 commits into
Conversation
Co-authored-by: akutuva21 <44119804+akutuva21@users.noreply.github.com>
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-authored-by: akutuva21 <44119804+akutuva21@users.noreply.github.com>
akutuva21
commented
Apr 13, 2026
Superseded by #94 csimulator assert->BNGError transition. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
🧹 Bolt: Replace assert statements with structured BNGErrors
What:
Replaced generic
assertstatements inbionetgen/simulator/csimulator.pywith structuredBNGSimulatorError(a subclass ofBNGError) and standardized error logging viaBNGLogger. Also addedBNGSimulatorErrortobionetgen.core.exc.Why:
To transition from generic assertions to specific custom exception classes for better error handling, traceability, and logging as part of an ongoing project convention update. This prevents application crashes with uninformative
AssertionErrors.Verification:
I manually verified the error raising mechanism through mock objects, ensuring that when unequal array lengths are supplied, the code successfully raises a
BNGSimulatorErrorand logs the message appropriately. Tests were run, and any pre-existing environment-related failures were unchanged.Result:
Safer error checking and logging implemented for simulation parameter setups.
PR created automatically by Jules for task 6233764973034024898 started by @akutuva21