Fix nbopen standard output and error handling in notebook generation - #89
Conversation
Co-authored-by: akutuva21 <44119804+akutuva21@users.noreply.github.com>
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Uh oh!
There was an error while loading. Please reload this page.
…kslashes Strip stray unquoted backslashes in action normalization
This commit resolves the
TODOcomment inbionetgen/core/main.pyregarding standard output and error handling for thenbopencommand. It correctly retrieves the streams from theapp.config(with robust error fallback usingAttributeErrorandKeyError), replacing the customrun_command(which didn't easily support arbitrary output destinations) with asubprocess.Popen.wait()combination that achieves correct behavior while being robust to invalid config values.PR created automatically by Jules for task 4118980527979395642 started by @akutuva21