⚡ perf(manifest): optimize setNested path handling - #6
Conversation
Updated `setNested` to accept an array of parts instead of a dotted path string, avoiding redundant string splitting. Tested with a 100,000 iteration benchmark on `parseMetadataYaml`, measuring ~20% improvement (from ~1.25s to ~0.98s). Co-authored-by: akutuva21 <44119804+akutuva21@users.noreply.github.com>
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
akutuva21
left a comment
There was a problem hiding this comment.
Reviewed in sequence. setNested path-parts optimization is a safe mechanical perf refactor with preserved behavior.
Uh oh!
There was an error while loading. Please reload this page.
💡 What: The optimization implemented
Modified
setNestedinscripts/generate-manifest.jsto take an array ofpartsdirectly instead of taking adottedPathstring and calling.split('.'). The call site insideparseMetadataYamlwas updated to pass thepathPartsarray instead of.join('.')ing it.🎯 Why: The performance problem it solves
The code was joining an array of path parts into a string, just for
setNestedto immediately split it back into an array to walk the object path. This introduced redundant CPU operations and memory allocations.📊 Measured Improvement:
Measured using a microbenchmark running
parseMetadataYamlfor 100,000 iterations:PR created automatically by Jules for task 15419023267491605790 started by @akutuva21