Conversation
Documents the end-to-end flow for governing huawei.com/Ascend910 (and similar) device-plugin resources with ClusterQueue / ResourceFlavor / LocalQueue, including the NPU-Operator node labels to select, a sample batch/Job manifest, the expected admission states, and the gotcha that nominalQuota must stay within node Allocatable. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
Your plan currently allows 1 review/hour. Refill in 46 minutes and 45 seconds. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more review capacity refills, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis PR adds documentation for managing Ascend NPU quotas with Kueue. It provides a complete workflow guide: identifying NPU node labels, creating ResourceFlavor and ClusterQueue manifests with quota settings, submitting jobs with queue labels, observing quota admission behavior through concrete kubectl output examples, and reference notes for production use. ChangesNPU Quota Management Guide
🎯 1 (Trivial) | ⏱️ ~3 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/en/kueue/how_to/npu_quota.mdx`:
- Around line 160-163: The docs show a kubectl command that pipes output to jq
but don't mention jq as a prerequisite; update the section around the kubectl
command `kubectl -n team-ascend get workload job-ascend-train-2-yyyyy -o
jsonpath='{.status.conditions}' | jq` to either (a) add a short prerequisite
bullet stating that jq is required (include a one-line install hint), or (b)
provide a no-jq alternative using only kubectl jsonpath output (showing the
equivalent kubectl-only invocation and brief note about its different
formatting). Ensure the text references the `-o jsonpath='{.status.conditions}'`
usage so readers know which variant applies.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 00b7935b-c36a-44cb-8e2d-218c4027a468
📒 Files selected for processing (1)
docs/en/kueue/how_to/npu_quota.mdx
The NPU Operator is a cluster-level plugin, not something installed on the Ascend nodes themselves. What surfaces huawei.com/Ascend910 on those nodes are the Driver, Ascend Device Plugin and Ascend Docker Runtime sub-components, which the operator's deployment form enables by default. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Both prerequisite bullets reference cluster-plugin identifiers shown in the Marketplace UI; matches the convention already used in install.mdx and gang_scheduling.mdx. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Deploying alauda-ai with
|
| Latest commit: |
b814bb2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://41ad2f68.alauda-ai.pages.dev |
| Branch Preview URL: | https://kueue-npu.alauda-ai.pages.dev |
Use kubectl -o yaml so the example works with a stock kubectl installation. Addresses review feedback on #233. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Documents the end-to-end flow for governing huawei.com/Ascend910 (and similar) device-plugin resources with ClusterQueue / ResourceFlavor / LocalQueue, including the NPU-Operator node labels to select, a sample batch/Job manifest, the expected admission states, and the gotcha that nominalQuota must stay within node Allocatable.
Summary by CodeRabbit
Release Notes