Improve ParserGenerator readability - #29
Open
djc wants to merge 5 commits into
Open
Conversation
djc
commented
Dec 29, 2014
ContributorAuthor
Merged with master, please consider (use |
djc
commented
Oct 6, 2015
ContributorAuthor
Hey @alex, any more feedback? |
djc
commented
Jul 23, 2018
ContributorAuthor
@alex this still applies after 3 years and was also useful when I was adding some debugging to the parser generator code. Please consider for merging or just close it if you think it's not an improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure why you wrote it this way, but adding a few empty lines, early continues and inverting conditions to handle simple cases first seems to me like it makes this code much more readable.