add cache_dir

[sn6uv]

New Cache API

[sn6uv]

I'd like to add an isinstance(cache_dir, basestring) check before the isdir call but this doesn't seem to behave nicely with RPython. Any suggestions?

[alex]

Is basestring really the correct type for paths? I think we should just pick unicode or bytes, whichever is correct, and use that.

[alex]

I'd kind of prefer to come up with a better API, e.g. cache=DirectoryCache("path"), with the default being DirectoryCache(tmpdir), that way someone can write the AppEngine cache or whatever else they asked for in another issue.

[sn6uv]

This could be problematic, that is, on Travis in particular.

[sn6uv]

Working with the App engine #24 should be relatively simple. Something like the following (totally untested) code should work:

classAppEngineCache(object):
VERSION=1def__init__(self, cache_id):
self.cache_id=cache_iddef_get_key(self, grammar_hash):
return"rply-%s-%s-%s"% (self.VERSION, self.cache_id, grammar_hash)
defload(self, grammar_hash):
cache_key=self._get_key(grammar_hash)
memcache.get(cache_key, namespace="rply")
defdump(self, grammar_hash, data):
cache_key=self._get_key(grammar_hash)
memcache.set(cache_key, data, namespace="rply")
cache=AppEngineCache('myid')
ParserGenerator(["VALUE"], cache=cache)

[sn6uv]

This conflicted with my other changes (in docs), so I've rebased on master.

I think this is ready now

[sn6uv]

Any word on this PR?

[sn6uv]

@alex any updates on this?