Skip to content

fix(types): allow mix of strings and arrays in facetFilters - #1384

Merged
Haroenv merged 1 commit into
algolia:masterfrom
eliasnorrby:fix/facetfilter-types
Jan 25, 2022
Merged

fix(types): allow mix of strings and arrays in facetFilters#1384
Haroenv merged 1 commit into
algolia:masterfrom
eliasnorrby:fix/facetfilter-types

Conversation

@eliasnorrby

Copy link
Copy Markdown

fixes: #1383

@codesandbox-ci

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e0ba486:

SandboxSource
javascript-client-appConfiguration

@HaroenvHaroenv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch, thanks!

@Haroenv
Haroenv merged commit dfc2a09 into algolia:masterJan 25, 2022
@bs-twic

Copy link
Copy Markdown

Hey! Any idea when this will be released to NPM?

@Haroenv

Copy link
Copy Markdown
Contributor

Sorry, I forgot this repo doesn't have automatic releases, will release tomorrow

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SearchOptions.facetFilters type is too restrictive

3 participants

@eliasnorrby@bs-twic@Haroenv