Skip to content

# fix(types): updating reRankingApplyFilter type and adding new property to RankingInfo - #1394

Merged
Haroenv merged 2 commits into
masterfrom
fix/update-reranking-filter-type
Feb 23, 2022
Merged

# fix(types): updating reRankingApplyFilter type and adding new property to RankingInfo#1394
Haroenv merged 2 commits into
masterfrom
fix/update-reranking-filter-type

Conversation

@alphonseb

@alphonsebalphonseb commented Feb 22, 2022•
edited
Loading

Copy link
Copy Markdown

fix(types): updating reRankingApplyFilter type and adding new property to RankingInfo

This is a follow up to #1378

What

  1. Adding null to the list of possible types for the reRankingApplyFilter search/setting option
  2. Adding property promotedByReRanking to the RankingInfo type.

Why

  1. This is how we reset the filter in the dashboard, it was an oversight in the first PR.
  2. Has been sent back by the engine for some time but was never added to the client's types.

@alphonsebalphonseb self-assigned this Feb 22, 2022
@codesandbox-ci

codesandbox-ciBot commented Feb 22, 2022•
edited
Loading

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 50209ca:

SandboxSource
algolia/create-instantsearch-appConfiguration

@alphonsebalphonseb changed the title fix(types): updating reRankingApplyFilter type# fix(types): updating reRankingApplyFilter type and adding new property to RankingInfoFeb 22, 2022
Haroenv
Haroenv approved these changes Feb 23, 2022
View reviewed changes

@HaroenvHaroenv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been added to the api client spec?

@Haroenv
Haroenv merged commit e8f08ed into masterFeb 23, 2022
@Haroenv
Haroenv deleted the fix/update-reranking-filter-type branch February 23, 2022 08:28
@shortcutsshortcuts mentioned this pull request Feb 25, 2022
Closed
@shortcutsshortcuts mentioned this pull request Jul 1, 2022
Merged
10 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HaroenvHaroenvHaroenv approved these changes

Assignees

@alphonsebalphonseb

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alphonseb@Haroenv