Uh oh!
There was an error while loading. Please reload this page.
feat(fetch-requester): add @algolia/requester-fetch - #1411
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cbebf59:
|
Haroenv
commented
Jun 24, 2022
First of all, thanks for this thorough pull request. It looks good on first glance, but I'll make sure to test it completely next week. It makes sense for the future (even across major) to keep xhr as the default (as you've done here), as there's some other environments that don't have fetch (ie, react native) |
There was a problem hiding this comment.
this looks great and works as expected (sandbox that uses it: https://codesandbox.io/s/javascript-client-app-forked-iwbbje?file=/src/app.js). Some small nitpicks are all I have to add
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
shortcuts
left a comment
There was a problem hiding this comment.
Nothing to add, thanks a lot for the contribution!
| "@wdio/static-server-service": "5.16.10", | ||
| "barrelsby": "2.2.0", | ||
| "bundlesize": "0.18.0", | ||
| "cross-fetch": "^3.1.5", |
There was a problem hiding this comment.
| "cross-fetch": "^3.1.5", | |
| "cross-fetch": "3.1.5", |
We can let renovate do the things
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
my2ter
commented
Jan 19, 2023
Thanks for this! Not sure if I'm missing something but unfortunately CloudFlare does not implement all parameters of the fetch api making it fails when I tried using it. I get a RetryError with the following: The 'mode' field on 'RequestInitializerDict' is not implemented If I comment out https://github.com/algolia/algoliasearch-client-javascript/blob/4.14.3/packages/requester-fetch/src/createFetchRequester.ts#L47 then it works. Npm deps:
Run locally: npx wrangler dev src/index.js |
Hey @my2ter! we've change the order of the parameters in v5 (https://github.com/algolia/algoliasearch-client-javascript/blob/next/packages/requester-fetch/src/createFetchRequester.ts#L39-L49), which allows the user to override the value for the If you wish to open the PR with the changes, please feel free! Otherwise I'll try to do it tomorrow |
Edge Computing such as Cloudflare Worker and Edge Functions (Vercel) do not support XHR or Node.js HTTP modules. add a requester that uses Fetch and Edge Computing. Algolia's JS client can be used with Edge Computing by adding a requester that uses Fetch.