Skip to content

fix(types): Updating searchoptions with explain attribute - #1415

Merged
Haroenv merged 2 commits into
masterfrom
feat/add-explain-attr
Jul 18, 2022
Merged

fix(types): Updating searchoptions with explain attribute#1415
Haroenv merged 2 commits into
masterfrom
feat/add-explain-attr

Conversation

@cdhawke

@cdhawkecdhawke commented Jul 18, 2022

Copy link
Copy Markdown
Contributor

Motivation

  • Update the SearchOptions to include explain as a typed parameter for better use within the Algolia dashboard

How

  • Adds the explain attribute as a string[] to the V4 SearchOptions.

Testing

  • Test cases shouldn't change. The attribute is already included in a search test here

@cdhawkecdhawke added the TypeScript Problems related to TypeScript definitions label Jul 18, 2022
@cdhawke
cdhawke requested a review from HaroenvJuly 18, 2022 13:47
@cdhawkecdhawke self-assigned this Jul 18, 2022
@codesandbox-ci

codesandbox-ciBot commented Jul 18, 2022•
edited
Loading

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c0a9119:

SandboxSource
javascript-client-appConfiguration

Haroenv
Haroenv reviewed Jul 18, 2022
View reviewed changes
Comment threadpackages/client-search/src/types/SearchOptions.ts Outdated
Comment threadpackages/client-search/src/types/SearchOptions.ts Outdated
@cdhawke
cdhawke requested a review from HaroenvJuly 18, 2022 14:08
@HaroenvHaroenv changed the title feat(client-search): Updating searchoptions with explain attributefix(types): Updating searchoptions with explain attributeJul 18, 2022
@Haroenv
Haroenv enabled auto-merge (squash) July 18, 2022 14:11
@shortcutsshortcuts mentioned this pull request Jul 18, 2022
Closed
@Haroenv
Haroenv merged commit c46932e into masterJul 18, 2022
@Haroenv
Haroenv deleted the feat/add-explain-attr branch July 18, 2022 14:52
@shortcutsshortcuts mentioned this pull request Apr 11, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HaroenvHaroenvHaroenv approved these changes

Assignees

@cdhawkecdhawke

Labels

TypeScriptProblems related to TypeScript definitions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cdhawke@Haroenv