Skip to content

feat: parse the sdi page - #18

Open
mikawudi wants to merge 4 commits into
alibaba:masterfrom
mikawudi:parse-sdipage
Open

feat: parse the sdi page#18
mikawudi wants to merge 4 commits into
alibaba:masterfrom
mikawudi:parse-sdipage

Conversation

@mikawudi

@mikawudimikawudi commented Dec 22, 2020

Copy link
Copy Markdown

parse the sdi page inner data

issue:#17

Signed-off-by: xujie mikawudi@qq.com

Signed-off-by: xujie <mikawudi@qq.com>
@codecov-io

codecov-io commented Dec 22, 2020

Copy link
Copy Markdown

Codecov Report

Merging #18 (12a5072) into master (3cb9bdb) will increase coverage by 0.15%.
The diff coverage is 84.09%.

Impacted file tree graph

@@ Coverage Diff @@## master #18 +/- ##
============================================
+ Coverage 82.32% 82.48% +0.15% - Complexity 1113 1131 +18 
============================================
Files 91 93 +2 Lines 4148 4236 +88 Branches 554 563 +9 ============================================
+ Hits 3415 3494 +79 - Misses 508 510 +2 - Partials 225 232 +7 
Impacted FilesCoverage ΔComplexity Δ
.../com/alibaba/innodb/java/reader/util/ZlibUtil.java76.47% <76.47%> (ø)2.00 <2.00> (?)
...ibaba/innodb/java/reader/page/index/SdiRecord.java81.39% <81.39%> (ø)11.00 <11.00> (?)
...a/com/alibaba/innodb/java/reader/page/SdiPage.java93.33% <92.85%> (-6.67%)4.00 <4.00> (+3.00)⬇️
...aba/innodb/java/reader/page/index/IndexHeader.java96.66% <0.00%> (ø)15.00% <0.00%> (ø%)
...om/alibaba/innodb/java/reader/util/SliceInput.java72.52% <0.00%> (+5.49%)29.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cb9bdb...12a5072. Read the comment docs.

@mikawudi

Copy link
Copy Markdown
Author

emm~any question in this pr?

@neoremind

Copy link
Copy Markdown
Collaborator

@mikawudi the code looks good, it would be better if you are willing to add a test case for sdi page.

@mikawudi

Copy link
Copy Markdown
Author

oki will add test case later

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter

codecov-commenter commented Aug 19, 2025

Copy link
Copy Markdown

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@mikawudi@codecov-io@neoremind@CLAassistant@codecov-commenter