Skip to content

Add protocol field to PullAndExtractOptions - #6

Merged
alongubkin merged 3 commits into
mainfrom
alon/alien-16-release-dockdash-020-with-protocol-support-for
Apr 12, 2026
Merged

Add protocol field to PullAndExtractOptions#6
alongubkin merged 3 commits into
mainfrom
alon/alien-16-release-dockdash-020-with-protocol-support-for

Conversation

@alongubkin

@alongubkinalongubkin commented Apr 12, 2026

Copy link
Copy Markdown
Member

Summary

  • Add protocol: ClientProtocol field to PullAndExtractOptions (defaults to HTTPS)
  • Add protocol() builder method to ImageBuilder
  • Pass protocol through to the OCI client in pull_and_extract() and build()

Why

The alien-manager starts an embedded local OCI registry for alien serve. The local platform needs to pull images from this registry over HTTP. Without the protocol field, pulls fail with TLS errors.

Test plan

  • cargo check passes
  • Existing tests pass
  • Verified end-to-end: alien E2E local pull test passes with HTTP protocol

Resolves ALIEN-16

🤖 Generated with Claude Code

alongubkinand others added 2 commits April 7, 2026 18:54
@alongubkin@claude
ci: automate releases with release-plz
5902360
Replace the manual release workflow with release-plz, which automatically
opens release PRs with version bumps and changelog updates, then tags,
creates GitHub Releases, and publishes to crates.io on merge.
Closes ALIEN-15
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@alongubkin@claude
Add protocol field to PullAndExtractOptions and ImageBuilder
1ac0d2b
Allows callers to specify HTTP vs HTTPS when pulling images.
Defaults to HTTPS. Needed for pulling from localhost registries
(embedded local OCI registry in alien-manager).
ALIEN-16
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@linear

linearBot commented Apr 12, 2026

Copy link
Copy Markdown
ALIEN-16 Release dockdash 0.2.0 with protocol support for PullAndExtractOptions

Context

The PullAndExtractOptions struct in dockdash is missing a protocol field. Image pulls always default to HTTPS, which breaks local development when pulling from the embedded local registry (HTTP only).

Changes needed

  • Add protocol: ClientProtocol field to PullAndExtractOptions (defaults to Https)
  • Add protocol() builder method to ImageBuilder
  • Pass protocol through to the OCI client in pull_and_extract() and build()
  • Bump version to 0.2.0
  • Publish to crates.io

Why

The alien-manager now starts an embedded local OCI registry for alien serve. The local platform's function manager needs to pull images from this registry over HTTP. Without the protocol field, pulls fail with TLS handshake errors (received corrupt message of type InvalidContentType).

After publishing

Update alien/Cargo.toml from dockdash = { path = "../dockdash" } back to dockdash = "0.2.0".

greptile-apps[bot]
greptile-appsBot reviewed Apr 12, 2026
View reviewed changes

@greptile-appsgreptile-appsBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@alongubkin
alongubkin merged commit a5db553 into mainApr 12, 2026
5 checks passed
@alongubkin
alongubkin deleted the alon/alien-16-release-dockdash-020-with-protocol-support-for branch April 12, 2026 19:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-appsgreptile-apps[bot]greptile-apps[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@alongubkin