SIM_LOG_DIR points to "${SCRIPT_DIR:?}"/log rather then /etc/astra-sim which requires sudo priviledges.

[marcodamico]

This solves #254

[Copilot]

Pull request overview

This PR addresses issue #254 by changing SIM_LOG_DIR in Astra-Sim build scripts from a system-level path (/etc/astra-sim) to a repo-local path ("${SCRIPT_DIR:?}"/log), avoiding the need for sudo during directory creation.

Changes:

• Update SIM_LOG_DIR in the top-level astra-sim-alibabacloud/build.sh to use a writable repo-local log/ directory.
• Update SIM_LOG_DIR in astra-sim-alibabacloud/build/astra_ns3/build.sh to use a script-local log/ directory.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
astra-sim-alibabacloud/build/astra_ns3/build.sh	Changes SIM_LOG_DIR away from /etc/astra-sim to avoid sudo-required paths in the ns3 build script.
astra-sim-alibabacloud/build.sh	Changes SIM_LOG_DIR away from /etc/astra-sim so the build creates log/input/result directories in a user-writable location.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[marcodamico]

Use repo-local SIM_LOG_DIR, avoid sudo-required /etc/astra-sim

• export SIM_LOG_DIR from top-level build.sh so child scripts inherit it
• ns3/build.sh inherits parent value or falls back to ../../log (same dir)
• remove undefined BUILD_DIR cd that aborted compile function early
• guard LOG_PATH and RESULT_PATH with #ifndef SIM_LOG_DIR; fall back to
  /etc/astra-sim when env var not set at cmake time
• phynet/CMakeLists.txt injects -DSIM_LOG_DIR when env var is present