Skip to content

#15 Fix fatal error with non-Gregorian locales#16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alphp merged 2 commits into from
Dec 18, 2023
Merged

#15 Fix fatal error with non-Gregorian locales #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a959850
#15 Fix fatal error with non-Gregorian locales
asmecher Dec 18, 2023
8b72060
Code review tweaks
asmecher Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/php-8.1-strftime.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -95,7 +95,11 @@ function strftime (string $format, $timestamp = null, ?string $locale = null) :
// in formatted strings.
// To adjust for this, a custom calendar can be supplied with a cutover date arbitrarily far in the past.
$calendar = IntlGregorianCalendar::createInstance();
$calendar->setGregorianChange(PHP_INT_MIN);
// NOTE: IntlGregorianCalendar::createInstance DOES NOT return an IntlGregorianCalendar instance when
// using a non-Gregorian locale (e.g. fa_IR)! In that case, setGregorianChange will not exist.
if ($calendar instanceof IntlGregorianCalendar) {
$calendar->setGregorianChange(PHP_INT_MIN);
}

return (new IntlDateFormatter($locale, $date_type, $time_type, $tz, $calendar, $pattern))->format($timestamp);
};
Expand Down