Uh oh!
There was an error while loading. Please reload this page.
Fix logging for tests and examples - #28
Conversation
🧩 Build Artifacts ✅ The following build artifacts were produced: |
There was a problem hiding this comment.
Code Review
This pull request refactors the logging system by removing the compile-time definition LCM_LOG_DEFAULT_ENABLED and defaulting logging to disabled. Logging is now explicitly enabled in the connmanctl example and via a new logging_init.cpp helper for specific tests. The review feedback highlights that some test targets might now lack logging due to the removal of the global definition and suggests using the [[maybe_unused]] attribute on the static initializer in logging_init.cpp to avoid potential compiler warnings.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Remove the use of the LCM_LOG_DEFAULT_ENABLED compile definition. LCM_LOG has to be enable always at runtime. Enable LCM_LOG at runtime for the tests and the example. This solves #24. Signed-off-by: Eduardo Gonzalez <eduardo.gonzalez@amarulasolutions.com>
🧩 Build Artifacts ✅ The following build artifacts were produced: |
Uh oh!
There was an error while loading. Please reload this page.
Remove the use of the LCM_LOG_DEFAULT_ENABLED compile definition. LCM_LOG has to be enable always at runtime.
Enable LCM_LOG at runtime for the tests and the example. This solves #24.