Skip to content

Do not block on request input - #31

Merged
EddyTheCo merged 3 commits into
developfrom
do_not_block_on_request_input
Apr 16, 2026
Merged

Do not block on request input#31
EddyTheCo merged 3 commits into
developfrom
do_not_block_on_request_input

Conversation

@EddyTheCo

@EddyTheCoEddyTheCo commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

No description provided.

gemini-code-assist[bot]
gemini-code-assistBot reviewed Apr 16, 2026
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Agent class to use a DBus object, introduces asynchronous input request handling via detached threads, and improves memory management and locking in the Manager class. Feedback identifies a critical use-after-free vulnerability in dispatch_method_call where a string is accessed after its parent variant is unreferenced, and highlights the risks of using detached threads without ensuring the lifetime of captured objects.

Comment threadsrc/dbus/gconnman_agent.cpp Outdated
Comment threadsrc/dbus/gconnman_agent.cpp
@github-actions

github-actionsBot commented Apr 16, 2026

Copy link
Copy Markdown

🧩 Build Artifacts

✅ The following build artifacts were produced:

@EddyTheCo
gagent: Do not block when requesting input
ae3cd5b
Store a pointer to dbus to finish the request input in the gdbus managed
context.
Spawn a thread that execute the request input callback so the user can
block as long as he wants for user input.
Signed-off-by: Eduardo Gonzalez <eduardo.gonzalez@amarulasolutions.com>
@EddyTheCo
gconnman_manager: Do not lock services more than needed
a34598e
A lock is used to protect concurrent access to the services structure,
once the service is found there is no need to continue locking the
resource.
The later allows to block the request input as long as the user want
without locking the services and other members of the manager.
Signed-off-by: Eduardo Gonzalez <eduardo.gonzalez@amarulasolutions.com>
@EddyTheCo
gconnman_manager: Fix parsing fields memory leak
895478f
Unref missing GPtrArray memory and add function to properly free field
description structs.
Signed-off-by: Eduardo Gonzalez <eduardo.gonzalez@amarulasolutions.com>
@EddyTheCo
EddyTheCoforce-pushed the do_not_block_on_request_input branch from c74f550 to 895478fCompareApril 16, 2026 15:32
@EddyTheCo
EddyTheCo merged commit 34c7b81 into developApr 16, 2026
2 checks passed
@github-actions

github-actionsBot commented Apr 16, 2026

Copy link
Copy Markdown

🧩 Build Artifacts

✅ The following build artifacts were produced:

@EddyTheCo
EddyTheCo deleted the do_not_block_on_request_input branch April 16, 2026 15:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@EddyTheCo