Skip to content

Add tethering - #35

Merged
EddyTheCo merged 3 commits into
amarula:developfrom
EddyTheCo:add_tethering
May 13, 2026
Merged

Add tethering#35
EddyTheCo merged 3 commits into
amarula:developfrom
EddyTheCo:add_tethering

Conversation

@EddyTheCo

@EddyTheCoEddyTheCo commented May 13, 2026

Copy link
Copy Markdown
Contributor

No description provided.

gemini-code-assist[bot]
gemini-code-assistBot reviewed May 13, 2026
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces tethering support to the connmanctl example and the underlying Technology D-Bus proxy, including the ability to configure SSID, passphrase, and frequency for WiFi tethering. The code review identified several critical issues that need to be addressed: a compilation error caused by a redundant class qualifier, a logic bug where tethering is hardcoded to enable regardless of user input, and flawed validation logic that prevents numeric passphrases from being set. Additionally, the use of std::stoi on unvalidated input poses a risk of unhandled exceptions, and a consistency improvement was suggested for handling the tethering frequency property type in the D-Bus communication layer.

Comment threadsrc/dbus/gconnman_technology.cpp Outdated
Comment threadexamples/connmanctl.cpp Outdated
Comment threadexamples/connmanctl.cpp Outdated
Comment threadexamples/connmanctl.cpp
Comment threadsrc/dbus/gconnman_technology.cpp
@github-actions

github-actionsBot commented May 13, 2026

Copy link
Copy Markdown

🧩 Build Artifacts

✅ The following build artifacts were produced:

@EddyTheCo
connman:technology: Add tethering methods
0383334
Add tethering-properties setting methods for the technologies.
Use unsigned int for storing the frequency.
Signed-off-by: Eduardo Gonzalez <eduardo.gonzalez@amarulasolutions.com>
@EddyTheCo
connmanctl.cpp: Stop using loop for technologies type match
377a66c
Signed-off-by: Eduardo Gonzalez <eduardo.gonzalez@amarulasolutions.com>
@EddyTheCo
connmanctl.cpp: Add tether command
51bf658
Signed-off-by: Eduardo Gonzalez <eduardo.gonzalez@amarulasolutions.com>
@github-actions

github-actionsBot commented May 13, 2026

Copy link
Copy Markdown

🧩 Build Artifacts

✅ The following build artifacts were produced:

@EddyTheCo
EddyTheCo merged commit ff0d1ce into amarula:developMay 13, 2026
2 checks passed
@EddyTheCo
EddyTheCo deleted the add_tethering branch May 13, 2026 09:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@EddyTheCo