Uh oh!
There was an error while loading. Please reload this page.
Use readline and add tethering - #38
Conversation
Connman could set the IPv6·privacy·option as prefered and also preferred. Add the misspelled property value to the map for the same key. Signed-off-by: Eduardo Gonzalez <eduardo.gonzalez@amarulasolutions.com>
Remove the print method of the different properties. The consumer should define the output stream to put the properties. Remove unused iostream header includes. Signed-off-by: Eduardo Gonzalez <eduardo.gonzalez@amarulasolutions.com>
Signed-off-by: Eduardo Gonzalez <eduardo.gonzalez@amarulasolutions.com>
There was a problem hiding this comment.
Code Review
This pull request integrates the readline library into the connmanctl example to provide command history and auto-completion, while also adding comprehensive support for tethering management along with corresponding test cases. Additionally, it refactors the property logging system to use standard stream operators and removes redundant header includes. Reviewers noted a misspelling in the IPv6 privacy configuration, potential runtime exceptions from std::stoi usage, limitations in the auto-completion logic for multi-argument commands, and a redundant thread notification call.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
🧩 Build Artifacts ✅ The following build artifacts were produced: |
Add readline in the connmanctl_dbus example. Allows completion, line editing, and interactive history while using the app. Improve command string manipulation and align better on how original connmanctl works. Signed-off-by: Eduardo Gonzalez <eduardo.gonzalez@amarulasolutions.com>
Signed-off-by: Eduardo Gonzalez <eduardo.gonzalez@amarulasolutions.com>
Add tethering-properties setting methods for the technologies. Signed-off-by: Eduardo Gonzalez <eduardo.gonzalez@amarulasolutions.com>
Signed-off-by: Eduardo Gonzalez <eduardo.gonzalez@amarulasolutions.com>
Signed-off-by: Eduardo Gonzalez <eduardo.gonzalez@amarulasolutions.com>
Signed-off-by: Eduardo Gonzalez <eduardo.gonzalez@amarulasolutions.com>
🧩 Build Artifacts ✅ The following build artifacts were produced: |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Use readline to add completion, line editing, and interactive history manipulation to the connmanctl_dbus example app.
Fix some small issues in the example and in the property value mapping of the services.
Remove the use of the standard output streams when getting properties. The consumer should define the output stream to put the properties.
Add methods to set the tethering properties of the technologies.
Add tethering tests.