Respond to github context about implementation - #1936
Conversation
Co-authored-by: amirbiron <amirbiron@gmail.com>
Cursor Agent can help with this pull request. Just |
🧯 Dangerous deletes guard reportPolicy: see .cursorrules — dangerous deletions are blocked unless wrapped safely. Summary:
Flagged findings (file:line:snippet): Excluded matches (by path pattern) |
⏱️ Performance report(No performance test durations collected. Mark tests with |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Co-authored-by: amirbiron <amirbiron@gmail.com>
Co-authored-by: amirbiron <amirbiron@gmail.com>
Co-authored-by: amirbiron <amirbiron@gmail.com>
Co-authored-by: amirbiron <amirbiron@gmail.com>
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: amirbiron <amirbiron@gmail.com>
📖 Documentation PreviewThe documentation has been built successfully!
To view locally:
|
Uh oh!
There was an error while loading. Please reload this page.
✨ תיאור קצר
בסוף עשינו מימוש מלא לפיצר ✔️
tmp/md-upload-demo.htmlהמדגים מיקום של כפתור העלאת תמונה (אייקון) בתוך שדה שם הקובץ. האייקון מופיע רק עבור קבצים עם סיומת.mdומאפשר בחירת תמונה, הצגת תצוגה מקדימה ופתיחה במסך מלא.📦 שינויים עיקריים
פירוט נקודות (רשימת תבליטים):
tmp/md-upload-demo.html) הכולל HTML, CSS ו-JavaScript..md.🧪 בדיקות
tmp/md-upload-demo.htmlבדפדפן.🧪 בדיקות נדרשות ב‑PR
📝 סוג שינוי
✅ צ'קליסט
🧩 השפעות/סיכונים
🔗 קישורים
🧯 סיכון / החזרה לאחור (Rollback)
tmp/md-upload-demo.html.Note
Adds end-to-end support for attaching images to
.mdfiles: upload with limits, store in Mongo, serve per-snippet, and display/manage in UI with previews and fullscreen; includes tests and a demo.MARKDOWN_IMAGE_LIMIT,MARKDOWN_IMAGE_MAX_BYTES, andALLOWED_MARKDOWN_IMAGE_TYPESwith env overrides inwebapp/app.py.POST /upload, acceptmd_imagesfor.mdfiles, validate type/size/count, and persist todb.markdown_imagesvia_save_markdown_images.GET /file/<file_id>/images/<image_id>to stream image bytes with proper headers; 404 on invalid/missing.view_file, fetchmarkdown_images(sorted byorder) and expose to template with per-imageurl.webapp/templates/upload.html): Add inline image button visible for.mdfilenames, client-side selection/limits, previews grid, remove, and fullscreen viewer; syncs files tomd_imagesinput.webapp/templates/view_file.html): Render attached images grid with open-in-overlay viewer.tests/test_markdown_images_api.py: Unit tests for the image serving endpoint (200/404, content-type, query correctness).tmp/md-upload-demo.html: Standalone HTML demonstrating the mobile-safe image upload UI for Markdown.Written by Cursor Bugbot for commit a90d70d. This will update automatically on new commits. Configure here.