מודאל בחירת ערכת נושא - #2828
Conversation
Co-authored-by: amirbiron <amirbiron@gmail.com>
Cursor Agent can help with this pull request. Just |
🧯 Dangerous deletes guard reportPolicy: see .cursorrules — dangerous deletions are blocked unless wrapped safely. Summary:
Flagged findings (file:line:snippet): Excluded matches (by path pattern) |
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
⏱️ Performance report(No performance test durations collected. Mark tests with |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 4 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: amirbiron <amirbiron@gmail.com>
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: amirbiron <amirbiron@gmail.com>
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: amirbiron <amirbiron@gmail.com>
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: amirbiron <amirbiron@gmail.com>
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Uh oh!
There was an error while loading. Please reload this page.
✨ תיאור קצר
מימשתי מודאל חדש לבחירת ערכות נושא, הנגיש מכפתור 🎨 בתפריט הקיצורים המהירים. המודאל כולל טאבים לסינון ערכות (מובנות, ציבוריות, אישיות), תצוגה מקדימה, לוגיקה לבחירה והחלת ערכות, וכן תמיכה בניווט מקלדת ושמירת פילטר.
📦 שינויים עיקריים
פירוט נקודות (רשימת תבליטים):
themePickerModal) ל-base.html.base.html, כולל כותרת, טאבים לסינון, רשת לתצוגת ערכות, ומחוון ערכה נוכחית.colorShift.initThemePicker) לטיפול בלוגיקת המודאל: פתיחה/סגירה, טעינת ערכות מובנות ומה-API, סינון, רינדור, בחירה והחלת ערכות, שמירת פילטר ב-sessionStorage, וניווט מקלדת./api/themes/list,/api/themes/shared/{id}/apply,/api/themes/{id}/activate,/api/user/preferences) לבחירה והחלת ערכות.🧪 בדיקות
base.htmlעברו בהצלחה.🧪 בדיקות נדרשות ב‑PR
📝 סוג שינוי
✅ צ'קליסט
services/register_jobs.py(כולל Callback/Trigger להפעלה ידנית — למשלcallback_name/trigger_funcלפי המבנה) כדי שיופיעו בדשבורדdocs/environment-variables.rstוגםservices/config_inspector_service.pydocs/webapp/theming_and_css.rst+FEATURE_SUGGESTIONS/theme_matrix.md🧩 השפעות/סיכונים
🔗 קישורים
🧯 סיכון / החזרה לאחור (Rollback)
base.htmlו-JavaScript, כך שהסרה שלהם תחזיר את המצב לקדמותו ללא תופעות לוואי.Note
Introduces a polished, accessible theme picker modal integrated into the quick-access menu for fast theme switching.
#themePickerModalinbase.html, including tabs (all/builtin/shared/custom), grid previews, current theme indicator, and keyboard navigation/api/themes/list; appliesbuiltininstantly (updatesdata-theme,localStorage, optional/api/ui_prefs) and appliesshared/customvia/api/themes/shared/{id}/applyor/api/themes/{id}/activatesessionStorage, highlights active theme, and shows lightweight toasts; closes the quick-access dropdown on openWritten by Cursor Bugbot for commit d83c5af. This will update automatically on new commits. Configure here.