docs: הרחבת שורת הטריגר — כל guard שמונע הערכה, לא רק isEnabledFor

[amirbiron]

תבנית Pull Request

✨ תיאור קצר

תיקון ניסוח לשורת הטריגר שנוספה ב-#3245. ריוויו על amir-bug-patterns PR #12 תפס שהניסוח מציג את isEnabledFor כ-guard היחיד שמונע הערכת ארגומנטים. זו הכללה: if verbose:, דגל פיצ'ר, או כל תנאי חוסם אחר עושים בדיוק אותו דבר. ריוויוור שקורא את השורה כפי שהיא עלול להחיל את הכלל רק על isEnabledFor ולפספס את השאר.

📦 שינויים עיקריים

• קוד (Backend)
• בוט טלגרם
• מסד נתונים/מיגרציות
• תיעוד (docs/)
• DevOps/CI/CD

פירוט נקודות:

• CLAUDE.md שורה 54 — עוטף אותה ב-isEnabledFor הוחלף ב-עוטף אותה ב-guard שמונע הערכת ארגומנטים.

למה לא נגעתי ב-integrations.py: באותו סבב ריוויו התגלה שהתיעוד ב-amir-bug-patterns טען דבר הפוך מהמציאות לגבי lazy=False. אימתתי מול המקור המותקן (PyGithub 2.9.1) ובהרצה שסופרת בקשות בפועל, והתמונה היא:

קריאה	בקשה נשלחת בבנייה
get_user()	לא
get_user(lazy=False)	כן
get_user(lazy=True)	לא
get_user("octocat")	כן

כלומר get_user(lazy=False) היה מנסח את הכוונה טוב יותר מהשורה _ = user.login שיש היום בבנאי. אבל הקוד הקיים נכון — נמדד: get_user() ואז גישה ל-login שולחים בדיוק בקשה אחת, ול-AuthenticatedUser אין את מלכודת גזירת השדה מה-URL שקיימת ב-NamedUser. מעבר ל-lazy=False היה מחייב לשכתב שלושה כפילים ב-tests/test_gist_per_user.py ולשנות את המשמעות של test_token_is_actually_validated_not_just_constructed, וזה שינוי בקוד ממוזג ועובד שלא נכלל בבקשה. מציע אותו כהמשך נפרד.

🧪 בדיקות

• Unit
• Integration
• Manual

שינוי ניסוח בקובץ מדיניות; אין קוד להריץ. הטענה שהניסוח נשען עליה אומתה בהרצה: עם רמת debug מנוטרלת הביטוי בתוך ה-f-string עדיין הוערך, ורק עטיפה בתנאי חוסם אפסה אותו.

🧪 בדיקות נדרשות ב‑PR

• 🔍 Code Quality & Security
• Unit Tests (3.11)
• Unit Tests (3.12)

📝 סוג שינוי

• docs: תיעוד

✅ צ'קליסט

• הקוד עוקב אחרי הסגנון
• בדיקות רצות ועוברות
• אין סודות/מפתחות בקוד
• אין מחיקות מסוכנות/פעולות על root
• הודעת הקומיט תואמת Conventional Commits
• תיעוד עודכן
• לא נוספו ג'ובים, משתני סביבה או טוקני עיצוב

🧩 השפעות/סיכונים

אין. שורה בקובץ מדיניות, ללא נגיעה בקוד רץ.

🔗 קישורים

• Issues קשורים: —
• ה-PR שהוסיף את השורה: docs: שורת טריגר לדפוס "פעולה שרוכבת על שורת לוג" #3245
• התיקון המקביל בכלל עצמו: amirbiron/amir-bug-patterns PR Fix render runtime error by removing file logging #12
• עיינתי ב-CodeBot – Project Docs — כן

🧯 סיכון / החזרה לאחור (Rollback)

git revert לקומיט הבודד.

---

Generated by Claude Code

Summary by Sourcery

Clarify the trigger guidance for preventing side effects on logging lines by referring to argument-evaluation guards generally.

Enhancements:

• Broaden the policy guidance to cover any guard that prevents argument evaluation, rather than singling out isEnabledFor.

Documentation:

• Update CLAUDE.md to clarify that log lines may be wrapped in any argument-evaluation guard when addressing side effects.

[sourcery-ai]

Sorry @amirbiron, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[qodo-code-review]

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

[coderabbitai]

Warning

Review limit reached

@amirbiron, you've reached your PR review limit, so we couldn't start this review.

Next review available in:35 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 74f3135c-d036-421b-bf8c-1c0113e195a0

📥 Commits

Reviewing files that changed from the base of the PR and between ba4db5d and 8bb6ed2.

📒 Files selected for processing (1)

• CLAUDE.md

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

🧯 Dangerous deletes guard report

Policy: see .cursorrules — dangerous deletions are blocked unless wrapped safely.

Summary:

• Flagged findings (blocking): 0
  0
• Excluded matches (not blocking): 15
• Total matches (all files): 129

Flagged findings (file:line:snippet):
(none)

Excluded matches (by path pattern)

./webapp/static/js/md_preview.bundle.js.map:4: "sourcesContent": ["// Markdown-it plugin to render GitHub-style task lists; see\n//\n// https://github.com/blog/1375-task-lists-in-gfm-issues-pulls-comments\n// https://github.com/blog/1825-t … [truncated]
./README.md:842:find . -name "__pycache__" -exec rm -rf {} +
./docs/DOCUMENTATION_GUIDE.md:453:rm -rf _build
./docs/Makefile:24:	rm -rf $(BUILDDIR)
./Dockerfile:42: rm -rf /var/lib/apt/lists/*
./Dockerfile:121: rm -rf /var/lib/apt/lists/*
./node_modules/katex/src/fonts/Makefile:139:	rm -rf pfa ff otf ttf woff woff2
./node_modules/katex/package.json:153: "build": "rimraf dist/ && mkdirp dist && cp README.md dist && rollup -c --failAfterWarnings && webpack && node update-sri.js package dist/README.md",
./node_modules/mermaid/dist/mermaid.js.map:4: "sourcesContent": ["/**\n* Default values for dimensions\n*/\nconst defaultIconDimensions = Object.freeze({\n\tleft: 0,\n\ttop: 0,\n\twidth: 16,\n\theight: 16\n});\n/**\n* Default values for tr … [truncated]
./node_modules/mermaid/dist/mermaid.min.js:1524:`,"getStyles"),c1e=RQe});var h1e={};dr(h1e,{diagram:()=>NQe});var NQe,f1e=N(()=>{"use strict";$ge();a1e();l1e();u1e();NQe={parser:Fge,db:n1e,renderer:o1e,styles:c1e}});var m1e,g1e=N(()=>{"use … [truncated]
./node_modules/mermaid/dist/chunks/mermaid.esm/chunk-2M32CCKP.mjs.map:4: "sourcesContent": ["{\n \"name\": \"mermaid\",\n \"version\": \"11.12.0\",\n \"description\": \"Markdown-ish syntax for generating flowcharts, mindmaps, sequence d … [truncated]
./node_modules/mermaid/dist/chunks/mermaid.core/chunk-KS23V3DP.mjs.map:4: "sourcesContent": ["{\n \"name\": \"mermaid\",\n \"version\": \"11.12.0\",\n \"description\": \"Markdown-ish syntax for generating flowcharts, mindmaps, sequence … [truncated]
./node_modules/mermaid/dist/chunks/mermaid.esm.min/chunk-4HFYJGYH.mjs.map:4: "sourcesContent": ["{\n \"name\": \"mermaid\",\n \"version\": \"11.12.0\",\n \"description\": \"Markdown-ish syntax for generating flowcharts, mindmaps, sequen … [truncated]
./node_modules/mermaid/dist/chunks/mermaid.esm.min/chunk-4HFYJGYH.mjs:1:var r={name:"mermaid",version:"11.12.0",description:"Markdown-ish syntax for generating flowcharts, mindmaps, sequence diagrams, class diagrams, gantt charts, git graph … [truncated]
./node_modules/mermaid/dist/mermaid.min.js.map:4: "sourcesContent": ["/**\n* Default values for dimensions\n*/\nconst defaultIconDimensions = Object.freeze({\n\tleft: 0,\n\ttop: 0,\n\twidth: 16,\n\theight: 16\n});\n/**\n* Default values fo … [truncated]

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates documentation wording in CLAUDE.md to generalize the description of the logging guard from a specific isEnabledFor call to any guard that prevents argument evaluation, aligning docs with actual behavior and related bug pattern rules.

File-Level Changes

Change	Details	Files
Generalize the logging guard description in the trigger row to cover any guard that prevents argument evaluation, not just isEnabledFor.	Reword the trigger description for log-line modifications to mention a generic guard that blocks argument evaluation instead of specifically naming isEnabledFor. Keep the reference to the existing bugbot rule side-effect-riding-on-log-line.md so the mapping from trigger to rule remains unchanged.	CLAUDE.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[github-actions]

⏱️ Performance report

• Run: https://github.com/amirbiron/CodeBot/actions/runs/32246802727
• Artifact: perf-durations

(No performance test durations collected. Mark tests with @pytest.mark.performance.)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[cubic-dev-ai]

No issues found across 1 file

<sub>Tip: cubic could auto-approve low-risk PRs like this, if it thinks it's safe to merge. Learn more

Re-trigger cubic</sub>