Uh oh!
There was an error while loading. Please reload this page.
feat(settings): overwrite existing preview settings rather than ignoring updates - #160
Merged
Merged
Conversation
neilmistryamplience
approved these changes
Oct 27, 2022
neilmistryamplience
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed and approved
petercoulton
approved these changes
Oct 27, 2022
petercoulton
approved these changes
Oct 27, 2022
rs-ampforce-pushed
the
fix/preview-overwrite
branch
from
October 28, 2022 08:23
16a8ce2 to
dd93e04ComparePureball pushed a commit
to cosnova/dc-cli
that referenced
this pull request
Aug 22, 2023
…ing updates (amplience#160) * feat(settings): overwrite existing preview settings rather than ignoring updates * feat(settings): new allowDelete option to allow removal of existing settings * test(settings): add documentation and tests for allowDelete option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, existing preview settings would not be touched when importing new ones. This PR allows new preview settings to overwrite existing ones, which is useful for overwriting the URL. Settings import still cannot delete preview settings.