Add profiling and throughput reporting to the benchmarks - #879
Open
alexander-beedie wants to merge 1 commit into
Open
Add profiling and throughput reporting to the benchmarks#879alexander-beedie wants to merge 1 commit into
alexander-beedie wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## master #879 +/- ##
==========================================
+ Coverage 97.13% 97.20% +0.07%
==========================================
Files 31 31 Lines 3663 3793 +130 Branches 328 344 +16 ==========================================
+ Hits 3558 3687 +129 - Misses 63 65 +2 + Partials 42 41 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking for opportunities to improve performance, I extended the benchmarking script with additional profiling and throughput info/options 👍
Three main additions:
A new
kB/sstat/columnScaling benchmarks only catch super-linear growth; a uniform slowdown would leave every exponent exactly where it was, bit would show up here.
--profileRuns each vector once (at its largest size) and print the hottest frames by
tottimebench_parse_throughput.pyCovers a selection of large/realistic SQL not found in the other scripts: CTEs, joins, window functions, UNION ALL chains, multi-statement scripts, comment-heavy text.
Found several nice speedups using the new flags, for which I'll make separate PRs shortly.