Fix isAbsoluteURL() regex - #286
Closed
andywer wants to merge 1 commit into
Closed
Conversation
andywer
commented
Aug 3, 2020
OwnerAuthor
@aminya I think I found the reason for the issue you ran into. It's just a one-liner. Can you monkey-patch the file in your local |
Contributor
Thank you! This does not solve the issue yet. I did not notice any difference. In implementation.browser.js, the code goes into the second if-else condition and this is the output of blob:file:///9f11280b-ad46-4df7-af45-97663a4a4abf |
aminya
commented
Aug 3, 2020
Contributor
Check the pull request I made here: #287 file:///C:/Users/myproject/ide-json/lib/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#284.