Uh oh!
There was an error while loading. Please reload this page.
Adding RTL support - #169
Conversation
widmoser
commented
Dec 9, 2015
Tests are still missing. Every test should be also replicated in RTL mode. |
SomeKittens
commented
Dec 10, 2015
Initial scan looks alright. Will give a full review when tests are added. |
There was a problem hiding this comment.
I removed the dependency of the code on the flow property variable. It only remains when setting the css. For one, this is a refactoring step that makes the code more readable in my opinion. But more importantly it is also more robust, because the position keeps being valid even if the flow property changes (in case the layout is switched to RTL for example). Without this change the position is stored in container.left (for example), which turns into container.right when switching to RTL, a problem that I wanted to avoid.
widmoser
commented
Feb 20, 2016
@SomeKittens: I've added tests for RTL layout. From my side the PR is ready. |
asaf050
commented
Jan 17, 2017
Hey, Thanks |
Adds right-to-left support for ui layout containers. This will automatically work as long as the
ui-layoutelement is a child of an element with a direction set tortl.Fixes issue #168.