Uh oh!
There was an error while loading. Please reload this page.
syntax refactor - #477
Conversation
coveralls
commented
Jul 20, 2016
| uiSortable: '=' | ||
| }, | ||
| link: function(scope, element, attrs, ngModel) { | ||
| 'use strict'; |
There was a problem hiding this comment.
I'm totally in favor of 'use strict', but this might cause errors in some ASP.Net environments.
jQuery prior v3 also didn't use 'use strict' for exactly that reason.
There was a problem hiding this comment.
Okay, I remove this line! Thanks!
coveralls
commented
Jul 20, 2016
| // if it's a custom option of the directive, | ||
| // handle it approprietly | ||
| if (key in directiveOpts) { | ||
| if (directiveOpts[key]) { |
There was a problem hiding this comment.
That's not equivalent in case of directiveOpts members with falsy values.
thgreasi
commented
Jul 20, 2016
Please don't create a hure diff. Try not moving methods until the initial refactor gets reviewed. |
Only syntax refactor,
return null;a in bwrite inb.awill more clear;_restoreand_destroywere simplified asdelete item.sortable.