@ngtools/webpack leaks TypeScript to subsequent loaders

[bytenik]

I've created a GitHub repository with a reproduction: https://github.com/bytenik/ngtools-webpack-babel

The repository is a nearly identical clone of your e2e test for @ngtools/webpack, except that I have installed babel-loader, added it into the webpack loaders in the config, and switched the tsconfig.json to target es2015. That last part actually doesn't matter -- this breaks even when targeting es5, but its hard to justify installing babel if you don't also have es2015 being spit out to babel. 😄

You'll see that babel starts producing errors on the ngfactory TypeScript files. However, babel shouldn't be receiving those files, but rather it should only be receiving compiled JS from you.

[jquince]

The way I read the documentation on loaders you have the order reversed in your configuration.
You have
{ test: /\.ts$/, loaders: ['@ngtools/webpack', 'babel-loader'] }
Should be
{ test: /\.ts$/, loaders: ['babel-loader', '@ngtools/webpack' ] }

See Webpack Loaders

[filipesilva]

Closing as answered by @jquince, thanks!

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}