Uh oh!
There was an error while loading. Please reload this page.
feat(route): add route generation - #139
Merged
Merged
Conversation
cironunes
commented
Jan 22, 2016
Member
@filipesilva please make sure to update this one as well |
filipesilva
commented
Jan 22, 2016
ContributorAuthor
Updated it just now. Edit: It was already up to date, there wasn't any change since my last commit. |
filipesilvaforce-pushed
the
route-generation
branch
from
January 23, 2016 10:41
4f5d018 to
4b4239fComparecironunes
commented
Jan 24, 2016
Member
It's missing the spec files for the services and components, can you add them? Closed #100 in favor of this. |
filipesilvaforce-pushed
the
route-generation
branch
from
January 31, 2016 18:23
4b4239f to
aae61eeComparefilipesilva
commented
Jan 31, 2016
ContributorAuthor
@cironunes I added the tests on components and services, and also added a e2e test for the command. |
Closed
Brocco
commented
Feb 1, 2016
Contributor
lgtm |
filipesilvaforce-pushed
the
route-generation
branch
from
February 1, 2016 21:15
aae61ee to
2991dd7CompareThis issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heavily, heavily inspired in the angular.io router guide.
This still needs some iteration, but at the moment it works as follows:
Generating a route
You can generate a new route by with the following command (note the singular
used in
hero):This will create a folder with a routable component (
hero-root.component.ts)with two sub-routes. The file structure will be as follows:
Afterwards to use the new route open your main app component, import
hero-root.component.tsand add it in the route config: