Uh oh!
There was an error while loading. Please reload this page.
fix(libs): 3rd party library install fixes - #160
Conversation
jkuri
commented
Jan 30, 2016
Btw, thanks to @Brocco for helping me with new prompt texts. |
There was a problem hiding this comment.
"with a/the package name"
missing "a/the"
There was a problem hiding this comment.
Thanks for noticing @cironunes, I fixed it.
filipesilva
commented
Jan 31, 2016
It looks like there's a lot less tests now. What is the reasoning? |
jkuri
commented
Jan 31, 2016
Before it was default that |
filipesilva
commented
Jan 31, 2016
Got it. Lgtm then! |
There was a problem hiding this comment.
minor: you can improve it to:
varallPackages={toInstall: [],toProccess: []};There was a problem hiding this comment.
Improved. Thanks for analyzing the code Ciro, if you find anything else please just add more notes.
There was a problem hiding this comment.
Can move this line to the top and use existSync on it on line 49?
cironunes
commented
Jan 31, 2016
Just added a few minor style improvements. Otherwise LGTM |
jkuri
commented
Jan 31, 2016
Fixed. Thanks. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Closes#152 and various other issues installing and injecting 3rd party libs.