Skip to content

feat(@schematics/angular): add solutions style tsconfig structure - #17586

Merged
mgechev merged 2 commits into
angular:masterfrom
alan-agius4:solutions-tsconfig
May 20, 2020
Merged

feat(@schematics/angular): add solutions style tsconfig structure#17586
mgechev merged 2 commits into
angular:masterfrom
alan-agius4:solutions-tsconfig

Conversation

@alan-agius4

@alan-agius4alan-agius4 commented Apr 30, 2020

Copy link
Copy Markdown
Collaborator

In version 3.9, TypeScript introduced the concept of "Solutions Style" tsconfig to improve developer experience.

More info: https://devblogs.microsoft.com/typescript/announcing-typescript-3-9-rc/#solution-style-tsconfig

Closes#17493 and closes#8138

@alan-agius4alan-agius4 added PR state: blocked target: major This PR is targeted for the next major release labels Apr 30, 2020
@alan-agius4alan-agius4 changed the title wip! add solutions tsconfigfeat(@schematics/angular): add solutions style tsconfig structureMay 4, 2020
@alan-agius4
alan-agius4 marked this pull request as ready for review May 6, 2020 12:52
@alan-agius4alan-agius4 added this to the V10-candidates milestone May 6, 2020
@alan-agius4
alan-agius4 requested review from IgorMinar and clydin and removed request for IgorMinarMay 6, 2020 16:46
@alan-agius4alan-agius4 added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels May 6, 2020
@alan-agius4

Copy link
Copy Markdown
CollaboratorAuthor

Blocking until support for TS 3.9 is landed in the framework. None the less, we should get this in a ready to be merged when that happens.

Comment threadtests/legacy-cli/e2e/utils/project.ts Outdated
@kyliau

Copy link
Copy Markdown
Contributor

We had a discussion whether the filename convention should be tsconfig-base.json or tsconfig.base.json. The former follows the same pattern used in the TS repo, whereas the latter allows the Angular workspace to enforce a consistent file naming.
Another concern is the convention used in google3. However, since google3 does not have plan to introduce solution-style tsconfig, the consideration is moot here.
We've decided to with tsconfig.base.json to ensure a consistent naming across Angular workspace.
cc: @IgorMinar

@alan-agius4alan-agius4 added action: merge The PR is ready for merge by the caretaker hotlist: release-blocker and removed action: merge The PR is ready for merge by the caretaker labels May 20, 2020

@IgorMinarIgorMinar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Comment threadintegration/angular_cli/tsconfig.base.json
@alan-agius4alan-agius4 added the action: merge The PR is ready for merge by the caretaker label May 20, 2020
@IgorMinar

Copy link
Copy Markdown
Contributor

We've decided to with tsconfig.base.json to ensure a consistent naming across Angular workspace.

Sounds great! thanks for documenting the decision making process.

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Jun 20, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakerhotlist: release-blockertarget: majorThis PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong jasmine/wd2 typings in Angular 8/9 tsconfig paths and module resolution errors in VS Code

6 participants

@alan-agius4@kyliau@IgorMinar@clydin@mgechev@googlebot