Skip to content

fix(service blueprint): Prevent unwanted ember service test generation - #217

Merged
filipesilva merged 1 commit into
angular:masterfrom
Brocco:remove-ember-service-test
Feb 18, 2016
Merged

fix(service blueprint): Prevent unwanted ember service test generation#217
filipesilva merged 1 commit into
angular:masterfrom
Brocco:remove-ember-service-test

Conversation

@Brocco

Copy link
Copy Markdown
Contributor

The ember-cli generates blueprints for when generating a new
By overriding in it prevents the ember service test generation
Fixes#202

@filipesilva

Copy link
Copy Markdown
Contributor

Sweet. Also need this for the routes command myself.

@Brocco

Copy link
Copy Markdown
ContributorAuthor

I'm updating this PR to also handle generated route tests

…eneration
The ember-cli generates blueprints for when generating a new service & route
By overriding in it prevents the ember service & route test generation
Fixesangular#202
@Brocco
Broccoforce-pushed the remove-ember-service-test branch from 366d1ae to 52b1b21CompareFebruary 18, 2016 12:19
@filipesilva

Copy link
Copy Markdown
Contributor

lgtm

@filipesilva
filipesilva merged commit 52b1b21 into angular:masterFeb 18, 2016
@Brocco
Brocco deleted the remove-ember-service-test branch February 19, 2016 14:08
clydin pushed a commit that referenced this pull request Jun 5, 2018
hansl pushed a commit that referenced this pull request Jun 6, 2018
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 9, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ng generate service also creates an ember test

2 participants

@Brocco@filipesilva