Uh oh!
There was an error while loading. Please reload this page.
chore(npm): updated webpack version and config cleanup - #2237
Conversation
| preLoaders: [ | ||
| loaders: [ | ||
| { | ||
| enforce: "left", |
| "typescript": "2.0.2", | ||
| "url-loader": "^0.5.7", | ||
| "webpack": "2.1.0-beta.22", | ||
| "webpack": "^2.1.0-beta.23", |
There was a problem hiding this comment.
Was working on that as we speak lol!
| "tslint": "^3.11.0", | ||
| "walk-sync": "^0.2.6" | ||
| "walk-sync": "^0.2.6", | ||
| "webpack": "^2.1.0-beta.23" |
There was a problem hiding this comment.
The angular-cli creates a new project, and the repo itself is a dev-dep of the generated project. So in the scope of the angular-cli, webpack is a dependency, not a dev dependency.
There was a problem hiding this comment.
A new project may look like this.
leon
commented
Sep 21, 2016
They renamed left/right to pre/post https://github.com/webpack/webpack/releases/tag/v2.1.0-beta.24 |
TheLarkInn
commented
Sep 22, 2016
@leon thanks, I'm aware I'm on the webpack core team!!! 😅 😅 Just hadn't had the time to get back to the PR with some <3<3 |
…ps://github.com/thelarkinn/angular-cli into feature/webpack_vesion_23_with_breaking_changes
TheLarkInn
commented
Sep 27, 2016
@hansl after careful inspection, I have been able on a test project to get this to run successfully, but have no idea what is causing the e2e test failures. One thing I have noticed is that whenever I run the e2e test runner locally I find that the builds are still running against webpack@2.1.0-beta.22 when they should be running against .25. See below. |
TheLarkInn
commented
Sep 27, 2016
Well hold that thought @filipesilva just mentioned that there are two package.json 🔥 that I have to update this in. I'm going to try this out locally first. |
…ps://github.com/thelarkinn/angular-cli into feature/webpack_vesion_23_with_breaking_changes
* chore(npm): updated webpack version and reworked configs for breaking changes * fix: swapped enforce rules by accident, fix this * fix: fix version, as well as convert loaders to rules for future api changes * chore: update webpack to beta.24 * chore(npm): updated webpack to beta.25 * chore(lint): remove rogue double quote * Added augmented module typings for webpack v2 supporting webpack.LoaderOptionsPlugin * chore(lint): linting chores spaces, return lines, semis * chore(npm): updated both package.jsons cause who forgets to do that
* chore(npm): updated webpack version and reworked configs for breaking changes * fix: swapped enforce rules by accident, fix this * fix: fix version, as well as convert loaders to rules for future api changes * chore: update webpack to beta.24 * chore(npm): updated webpack to beta.25 * chore(lint): remove rogue double quote * Added augmented module typings for webpack v2 supporting webpack.LoaderOptionsPlugin * chore(lint): linting chores spaces, return lines, semis * chore(npm): updated both package.jsons cause who forgets to do that
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Uh oh!
There was an error while loading. Please reload this page.