Skip to content

fix(ci): correctly report appveyor failures - #2238

Merged
filipesilva merged 2 commits into
angular:masterfrom
filipesilva:fix-appveyor-script
Sep 27, 2016
Merged

fix(ci): correctly report appveyor failures#2238
filipesilva merged 2 commits into
angular:masterfrom
filipesilva:fix-appveyor-script

Conversation

@filipesilva

@filipesilvafilipesilva commented Sep 20, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@filipesilva
filipesilvaforce-pushed the fix-appveyor-script branch 4 times, most recently from ae77dfb to 43e3f57CompareSeptember 20, 2016 04:46
TheLarkInn
TheLarkInn approved these changes Sep 20, 2016
View reviewed changes

@TheLarkInnTheLarkInn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. unless @hansl spots something himself.

@filipesilva

filipesilva commented Sep 20, 2016

Copy link
Copy Markdown
ContributorAuthor

There's something wrong still, at least on windows. The CI should fail, and it isn't failing.

@filipesilva

filipesilva commented Sep 20, 2016•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

It's not a windows problem apparently, npm test has failures on linux as well but the CI passes:
travis - https://travis-ci.org/angular/angular-cli/jobs/161231177#L2049
appveyour - https://ci.appveyor.com/project/AngularCLI/angular-cli/build/1.0.2861/job/nowqpp3boup5o4a1#L1828

@filipesilva
filipesilvaforce-pushed the fix-appveyor-script branch 2 times, most recently from 868b98b to 8f4c898CompareSeptember 27, 2016 12:28
@filipesilva

filipesilva commented Sep 27, 2016

Copy link
Copy Markdown
ContributorAuthor

Turns out that you must manually set the exit code when not using the default reporter.

@filipesilva
filipesilva merged commit 3102453 into angular:masterSep 27, 2016
@filipesilva
filipesilva deleted the fix-appveyor-script branch September 27, 2016 18:39
JJayet pushed a commit to JJayet/angular-cli that referenced this pull request Oct 2, 2016
@filipesilvaJonathan Jayet
fix(test): correctly report packages spec failures (angular#2238)
3aff7ad
deebloo pushed a commit to deebloo/angular-cli that referenced this pull request Oct 3, 2016
@filipesilvaDanny Blue
fix(test): correctly report packages spec failures (angular#2238)
c395f2d
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 10, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers
@hanslhanslhansl approved these changes
@BroccoBroccoBrocco approved these changes
@TheLarkInnTheLarkInnTheLarkInn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@filipesilva@hansl@Brocco@TheLarkInn@googlebot