Skip to content

bugfix(generate): removes bad imports when generating a class - #2292

Closed
deebloo wants to merge 28 commits into
angular:masterfrom
deebloo:2288
Closed

bugfix(generate): removes bad imports when generating a class#2292
deebloo wants to merge 28 commits into
angular:masterfrom
deebloo:2288

Conversation

@deebloo

@deebloodeebloo commented Sep 22, 2016

Copy link
Copy Markdown
Contributor

closes#2288

@JohannesRudolph

JohannesRudolph commented Sep 27, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

@deebloo unfortunately the build failed. can you rebase/merge and retest your pull request?

@deebloodeebloo changed the title bugfix(2288): removes bad imports when generating a classbugfix(generate): removes bad imports when generating a classSep 28, 2016
filipesilva
filipesilva suggested changes Oct 3, 2016
View reviewed changes
Comment threadtests/e2e/tests/generate/class.ts
return ng('generate', 'class', 'test-class')
.then(() => expectFileToExist(classDir))
.then(() => expectFileToExist(join(classDir, 'test-class.ts')))
.then(() => expectFileToExist(join(classDir, 'test-class.spec.ts')))

@filipesilvafilipesilvaOct 3, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just changed to default to not having a spec in #2475 I believe.

@filipesilva

filipesilva commented Oct 3, 2016

Copy link
Copy Markdown
Contributor

Hey, thanks for fixing this! Don't worry too much about keeping the PR updated though, I usually batch-rebase/merge them myself.

In your case though, a couple of hours ago a change landed that removed the default specs from classes so it really needs to be rebased.

@deebloo

deebloo commented Oct 3, 2016

Copy link
Copy Markdown
ContributorAuthor

@filipesilva oh boy does it!

Danny Blueand others added 14 commits October 3, 2016 14:11
Danny Blue
Merge branch 'master' ofhttps://github.com/angular/angular-cliinto …
584fdc5
…2288
Danny Blue
remove unneeded imports
775629a
Danny Blue
add unit tests for generating class
2f10fdf
Danny Blue
fix var name
7db3bdb
@BroccoDanny Blue
feature(route): allow lazy route reference by relative paths (angular…
a8b3df2
…#2434)
@BroccoDanny Blue
bug(route): fix the class names for --routing in ng new (angular#2435)
a499841
Fixesangular#2433
@BroccoDanny Blue
feature(new): allow specification of --inline-style & --inline-templa…
bbea59e
…te for new apps (angular#2455)
Fixesangular#2446
@BroccoDanny Blue
feature(config): config inline template & style in angular-cli.json (a…
a3b0fbd
…ngular#2457)
Fixesangular#2447
@filipesilvaDanny Blue
chore(new): remove blueprint option (angular#2390)
5ed8d38
@filipesilvaDanny Blue
fix(build): use baseUrl and paths from tsconfig (angular#2470)
5ad8754
@catullDanny Blue
chore(completion): ng completion update for command options (angular#…
32c5feb
…2379)
* Updated ng command options.
- "build" now additionally supports --base-hre / -bh, -w
- "generate" got cleaned up
- "github-pages:deploy" / "gh-pages:deploy" now is supported, too
- "init" now knows --routing and --source-dir
- "new" also accepts --routing
- "serve" dumped --insecure-proxy, --inspr, --output-path, -op, -out and -pxy
- "test" now honours --build and --reporters, dumped --config-file, --environment, --filter, --host, --launch, --module, path, --query, reporter, --server, --silent, --test-page and --test-port
* Added --aot for "build" and "serve".
* Recent the commands "init" and "new" received two more options: "--inline-stile" (alias -is) and "inline-template" (alias -it). Support the, both.
* Recently the commands "init" and "new" dropped --blueprint (alias -b).
@filipesilvaDanny Blue
chore(ci): use node 4 instead of 5 (angular#2469)
360274f
@hanslDanny Blue
feat(aot): creating files in a virtual fs. (angular#2464)
e1d9930
In addition, reading and using AST on main.ts to figure out the entry module, if not specified.
@BroccoDanny Blue
feature(blueprints): add spec/no-spec flags to all blueprints (angula…
961c355
…r#2382)
Fixesangular#2108
@googlebot

googlebot commented Oct 3, 2016

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@deebloo

deebloo commented Oct 3, 2016

Copy link
Copy Markdown
ContributorAuthor

@filipesilva made a mess. Will open new PR

@deebloodeebloo closed this Oct 3, 2016
@HennerMHennerM mentioned this pull request Oct 19, 2016
Closed
@deebloo
deebloo deleted the 2288 branch October 28, 2016 17:42
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 10, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@filipesilvafilipesilvafilipesilva requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@angular/core/testing has no exported member addProviders

7 participants

@deebloo@JohannesRudolph@filipesilva@googlebot@Brocco@catull@hansl