Uh oh!
There was an error while loading. Please reload this page.
feat(github): support usage of gh-token for deployment from external env - #3121
Conversation
ec73994 to
223d343Comparedavinkevin
commented
Nov 18, 2016
I maintain the branch up-to-date since the PR, could you say me if you are interested by this PR or not ? Thanks you |
filipesilva
commented
Dec 8, 2016
@davinkevin can you add some tests for this? The appropriate file is https://github.com/angular/angular-cli/blob/master/tests/acceptance/github-pages-deploy.spec.js |
davinkevin
commented
Dec 8, 2016
I've already made it : https://github.com/angular/angular-cli/pull/3121/files#diff-86b4ebf8ce530235f5d984c72660361e I will sync the branch with the current head |
87e72d7 to
b29126dComparedavinkevin
commented
Dec 9, 2016
Synced with master and test updated You can, @filipesilva review it when you want 😄 Thanks |
b29126d to
3f5ea9cComparedavinkevin
commented
Dec 18, 2016
The branch is synced with the master... if you want to integrate it ;) |
filipesilva
left a comment
There was a problem hiding this comment.
Heya, sorry I took so long to get back to this PR again. There's just the tests/runner.js change that I'd like to revert, and other than that it LGTM.
| var root = 'tests/{acceptance,models}'; | ||
| var specFiles = glob.sync(root + '/**/*.spec.*'); | ||
| var specFiles = glob.sync(root + '/**/github-pages-deploy.spec.*'); |
There was a problem hiding this comment.
Can you remove this? I know why you added it, I do it myself while testing, but for merging it can't be there :D
3f5ea9c to
bb81d64Compare@filipesilva Sorry, I totally forgot to remove it during the last sync with master... 😞 It has been removed and synced again with master ;) |
filipesilva
commented
Dec 21, 2016
@davinkevin you sure you removed it? I still see it in the PR. |
bb81d64 to
d94042cComparedavinkevin
commented
Dec 21, 2016
@filipesilva Sorry (again), I try to do too many things at the same time... I've checked, now, my working tree is now clean and the modification aren't in the "File changed" tab. Thanks for your time ;) |
235a48e to
dce7709Comparedce7709 to
392ce31CompareIn order to being able to push to github from CI (Travis for example), we should be able to provide a token to the cli, as `--gh-token=XYZ`. This modification allow to use this token in the destination url. This also allow user to push to another github repository if it uses a different `--gh-username` from the one used for the checkout.
392ce31 to
c94eebaComparedavinkevin
commented
Jan 5, 2017
Synced with head to solve conflicts 😉 |
…rom external env (angular#3121) In order to being able to push to github from CI (Travis for example), we should be able to provide a token to the cli, as `--gh-token=XYZ`. This modification allow to use this token in the destination url. This also allow user to push to another github repository if it uses a different `--gh-username` from the one used for the checkout.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
In order to being able to push to github from CI (Travis for example), we should be able to provide a token to the cli, as
--gh-token=XYZ. This modification allow to use this token in the destination url. This also allow user to push to another github repository if it uses a different--gh-usernamefrom the one used for the checkout.