add support for publicPath option in webpack by Mischi · Pull Request #3136 · angular/angular-cli

Mischi · 2016-11-14T20:53:05Z

Hi all,

this PR tries to add the publicPath option for webpack.
I have not figured out how to test this feature yet? Would be happy for any suggestions though 😃

Personally i would like to use this feature to easily integrate angular-cli based projects into ASP.NET MVC applications but there are many other valid use cases for publicPath option. See BROCKHAUS-AG/AspNetAngular2IntegrationDemo for a simple demo ...

This should also fix#2276.

Cheers,
Fabian

clydin · 2016-11-14T22:31:13Z

Changing the base href doesn't do what you need?

Mischi · 2016-11-14T22:44:07Z

Hi,

using base href works kind of. The problem with using base href is that it will also affect ajax calls which in my case is not what i want ...

clydin · 2016-11-15T04:43:06Z

You can either use root relative urls or provide an app wide config object with an api base url which can be prefixed to all ajax calls (good practice anyway in case the static content is split from the API in the future).

The nice thing about setting the base href is that it handles index.html, webpack, and angular routing all in one place.

Mischi · 2016-11-15T06:11:59Z

You can either use root relative urls or provide an app wide config object with an api base url which can be prefixed to all ajax calls (good practice anyway in case the static content is split from the API in the future).

Yes, that works. Thanks!

But it doesn't feel correct to me though since my index.html is served on http://localhost:8080/ and all assets are below http://localhost:8080/Content/. Using base href would feel more correct if my index.html would be served from http://localhost:8080/Content/ too. But maybe that's just my lack of understanding as it seems to work with base href ....

Btw, my application structure looks like this:

ClientApp (angular-cli project)
- angular-cli.json
Controllers
- HomeController (serves ../Content/index.html on http://localhost:8080/)
Content (outDir)
- index.html
- main.bundle.js
- ...

Mischi · 2016-11-15T21:31:07Z

After playing a little bit more with --base-href i am pretty sure that --base-href is NOT what i want in my case.

I prepared two demos which demonstrate the difference between --basic-href and publicPath as i propose in this PR.

The --basic-href demo (http://ngcli-basehref.azurewebsites.net/) will use the --base-href "/Content" for routing too as you noticed which is not what i want.

If you compare this with the publicPath demo (http://ngcli-publicpath.azurewebsites.net/) you will notice, that /Content is only used for assets and not for routing.

@clydin, do you know a way i can archive this without publicPath?

Thanks in advance,
Fabian

clydin · 2016-11-16T01:04:05Z

Add this to your app module:

providers: [{provide: APP_BASE_HREF, useValue: '/'}]

As to the PR, I think that two options that perform similar functions but with slightly different outcomes could lead to confusion. Some guides on different hosting strategies would probably be useful regardless.

Mischi · 2016-11-16T18:52:34Z

Thanks again!

jbellmann · 2016-11-17T15:49:11Z

@Mischi
Why did you close this PR? You don't want it merged anymore? I have seen lots of issues about this "publicPath"-config option.

Mischi · 2016-11-18T21:13:44Z

Hi @jbellmann, the solution @clydin proposed works for my current project but if you care i can reopen it.

andyg3 · 2016-11-18T21:23:28Z

The solution from @clydin doesn't work in my case. I definitely need publicPath supported.

jbellmann · 2016-11-18T23:08:04Z

@Mischi

please notice my PR into your feature-branch. Contains only the missing test.

clydin · 2016-11-18T23:14:04Z

@andyg3 feel free to open an issue to discuss your use case

# Conflicts: # packages/angular-cli/models/webpack-build-common.ts

googlebot · 2016-11-19T11:46:02Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

googlebot · 2016-11-19T11:59:02Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

googlebot · 2016-11-19T12:03:15Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

jbellmann · 2016-11-21T18:18:47Z

@here I signed the CLA, but somehow the @googlebot is not checking again.

andyg3 · 2016-11-21T22:31:14Z

Is there a way to kick the @googlebot into re-checking this?

changLiuUNSW · 2016-11-24T00:17:36Z

Is there any update with this? I really need publicPath support.

jbellmann · 2016-11-24T00:37:44Z

@Mischi

I merged latest changes from master and created a PR for your feature-branch.

Is there an easier way to handle this?

Regards,
Jörg

rsnj · 2016-11-24T02:17:57Z

I really need publicPath support as well. Will be great to get this merged in.

changLiuUNSW · 2016-11-25T13:15:55Z

I think this one can be closed
Another PR created including command line support and unit test
#3285

filipesilva · 2016-12-08T11:32:45Z

Superseded by #3285, as it is more complete.

…3285) Add publicPath option for webpack. User can specify publicPath via `--deploy-url` / `-d` from command line or add `deployUrl` to `angular-cli.json`. It can solve following issues: Change the public URL address of the output files (different from baseUrl). Manipulate the request url for chunk js files. It is very helpful to solve resources url and route lazying load issues for those applications which have different static files paths such as ASP.NET MVC. Fixes#3136Fixes#2960Fixes#2276Fixes#2241Fixes#3344

…ngular#3285) Add publicPath option for webpack. User can specify publicPath via `--deploy-url` / `-d` from command line or add `deployUrl` to `angular-cli.json`. It can solve following issues: Change the public URL address of the output files (different from baseUrl). Manipulate the request url for chunk js files. It is very helpful to solve resources url and route lazying load issues for those applications which have different static files paths such as ASP.NET MVC. Fixesangular#3136Fixesangular#2960Fixesangular#2276Fixesangular#2241Fixesangular#3344

angular-automatic-lock-bot · 2019-09-11T17:42:16Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

…ngular#3285) Add publicPath option for webpack. User can specify publicPath via `--deploy-url` / `-d` from command line or add `deployUrl` to `angular-cli.json`. It can solve following issues: Change the public URL address of the output files (different from baseUrl). Manipulate the request url for chunk js files. It is very helpful to solve resources url and route lazying load issues for those applications which have different static files paths such as ASP.NET MVC. Fixesangular#3136Fixesangular#2960Fixesangular#2276Fixesangular#2241Fixesangular#3344

Mischi added 2 commits November 14, 2016 21:24

add publicPath to the config schema
1d6120f

pass "publicPath" from the config to webpack
fa882aa

googlebot added the cla: yes label Nov 14, 2016

Mischi closed this Nov 16, 2016

Mischi reopened this Nov 18, 2016

jbellmannand others added 2 commits November 19, 2016 12:45

test for 'publicPath' config
87b0b3e

Merge branch 'master' into feat-webpack-publicPath
d012772
# Conflicts: # packages/angular-cli/models/webpack-build-common.ts

googlebot added cla: no and removed cla: yes labels Nov 19, 2016

Mischi force-pushed the feat-webpack-publicPath branch from 130d5c4 to 87b0b3eCompare November 19, 2016 12:03

This was referenced Nov 24, 2016
Question: Is it possible to host angular-cli generated app in an ASP.NET MVC project? #2960
Closed
feat(build): add publicPath support via command and angular-cli.json #3285
Merged

filoxo mentioned this pull request Dec 2, 2016
add support for publicPath #3344
Closed

filipesilva closed this Dec 8, 2016

angular-automatic-lock-botBot locked and limited conversation to collaborators Sep 11, 2019

Uh oh!

Conversation

Mischi commented Nov 14, 2016

Uh oh!

clydin commented Nov 14, 2016

Uh oh!

Mischi commented Nov 14, 2016

Uh oh!

clydin commented Nov 15, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mischi commented Nov 15, 2016

Uh oh!

Mischi commented Nov 15, 2016

Uh oh!

clydin commented Nov 16, 2016

Uh oh!

Mischi commented Nov 16, 2016

Uh oh!

jbellmann commented Nov 17, 2016

Uh oh!

Mischi commented Nov 18, 2016

Uh oh!

andyg3 commented Nov 18, 2016

Uh oh!

jbellmann commented Nov 18, 2016

Uh oh!

clydin commented Nov 18, 2016

Uh oh!

googlebot commented Nov 19, 2016

Uh oh!

googlebot commented Nov 19, 2016

Uh oh!

googlebot commented Nov 19, 2016

Uh oh!

jbellmann commented Nov 21, 2016

Uh oh!

andyg3 commented Nov 21, 2016

Uh oh!

changLiuUNSW commented Nov 24, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jbellmann commented Nov 24, 2016

Uh oh!

rsnj commented Nov 24, 2016

Uh oh!

changLiuUNSW commented Nov 25, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

filipesilva commented Dec 8, 2016

Uh oh!

angular-automatic-lock-botBot commented Sep 11, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

clydin commented Nov 15, 2016•
edited
Loading

changLiuUNSW commented Nov 24, 2016•
edited
Loading

changLiuUNSW commented Nov 25, 2016•
edited
Loading