Skip to content

feat(build production): introduce the production build - #329

Merged
cironunes merged 1 commit into
angular:masterfrom
cironunes:feature/production-build
Apr 4, 2016
Merged

feat(build production): introduce the production build#329
cironunes merged 1 commit into
angular:masterfrom
cironunes:feature/production-build

Conversation

@cironunes

@cironunescironunes commented Mar 20, 2016

Copy link
Copy Markdown
Member

For production build:

  • removed live reload references (still not 100%)
  • stopped copying tests and .ts files + tsconfig.json

Missing:

Closes#41

@cironunes

cironunes commented Mar 20, 2016

Copy link
Copy Markdown
MemberAuthor

I'm not sure if this is the best approach. I was trying to create the build command and extend the ember-cli, but I got stuck at some point and just decided to deliver something so you guys can give feedback.

/cc @angular/angular-cli-team

@hansl

hansl commented Mar 21, 2016

Copy link
Copy Markdown
Contributor

Looks good but Angular2App was changed significantly this weekend

@cironunes

cironunes commented Mar 21, 2016

Copy link
Copy Markdown
MemberAuthor

I'll update it accordingly today.

@cironunes
cironunesforce-pushed the feature/production-build branch 2 times, most recently from e50f8e8 to 7febeb3CompareMarch 24, 2016 21:09
@hansl

hansl commented Mar 24, 2016

Copy link
Copy Markdown
Contributor

Cool. LGTM :)

We'll need to improve a LOT but this is a good first step.

@cironunes
cironunesforce-pushed the feature/production-build branch 6 times, most recently from 4cd01e1 to 5f37828CompareMarch 27, 2016 20:17
@hansl

hansl commented Mar 29, 2016

Copy link
Copy Markdown
Contributor

You'll have to rebase again. We're getting closer though. I can help with the rest :)

@cironunes

cironunes commented Mar 30, 2016

Copy link
Copy Markdown
MemberAuthor

I'll do that soon :)

@cironunes
cironunesforce-pushed the feature/production-build branch from 5f37828 to 85fd073CompareApril 2, 2016 22:08
hansl
hansl reviewed Apr 3, 2016
View reviewed changes
Comment threadlib/broccoli/angular2-app.js Outdated
@method _getDotfilesTree
@return {Tree} The dotfiles exclusion tree.
*/
Angular2App.prototype._getDotfilesTree = function () {

@hanslhanslApr 3, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose of this is more _getPublicTree.

@hansl

hansl commented Apr 3, 2016

Copy link
Copy Markdown
Contributor

Very good. A few nits. Could you also squash your commits into 1?

I think this is very close to being done.

@cironunes
cironunesforce-pushed the feature/production-build branch from 85fd073 to a058996CompareApril 3, 2016 22:23
@hansl

hansl commented Apr 3, 2016

Copy link
Copy Markdown
Contributor

LGTM.

@cironunes
cironunes merged commit a058996 into angular:masterApr 4, 2016
@cironunes
cironunes deleted the feature/production-build branch April 7, 2016 13:03
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 9, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 9, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@hanslhansl

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Production build

2 participants

@cironunes@hansl