Uh oh!
There was an error while loading. Please reload this page.
fix(generate): fix style and template url references - #341
Merged
Conversation
| locals: function(options) { | ||
| return { | ||
| dynamicPath: this.dynamicPath.dir | ||
| dynamicPath: this.dynamicPath.dir === path.sep |
Contributor
There was a problem hiding this comment.
this sounds like a path.resolve(this.dynamicPath.dir) or something like that, no?
hansl
commented
Mar 23, 2016
Contributor
Please add a test for this. |
Broccoforce-pushed
the
dynamic-path-ref
branch
2 times, most recently
from
March 23, 2016 18:55
78e7374 to
fbe6cbaCompare| @@ -1,5 +1,6 @@ | |||
| var stringUtils = require('ember-cli/lib/utilities/string'); | |||
| var dynamicPathParser = require('../../utilities/dynamic-path-parser'); | |||
| var path = require('path'); | |||
hansl
commented
Mar 23, 2016
Contributor
2 nits, but LGTM. Stamping this. Good work! :) |
Dynamic paths for components were incorrectly generating paths for templates and styles Fixesangular#340
Brocco
commented
Mar 23, 2016
ContributorAuthor
Thanks @hansl nits have been handled/updated |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dynamic paths for components were incorrectly generating paths for templates and styles
Fixes#340