Skip to content

chore(formatting): correction for package.json - #346

Merged
zackarychapple merged 1 commit into
angular:masterfrom
zackarychapple:travis-eslint
Mar 25, 2016
Merged

chore(formatting): correction for package.json#346
zackarychapple merged 1 commit into
angular:masterfrom
zackarychapple:travis-eslint

Conversation

@zackarychapple

Copy link
Copy Markdown
Contributor

chore(formatting): correction for package.json

realized a change snuck in on the package.json that disables the tests command from running tests

@zackarychapplezackarychapple changed the title chore(formatting): updating travis to run eslint, and correction for package.jsonchore(formatting): correction for package.jsonMar 25, 2016
@filipesilva

Copy link
Copy Markdown
Contributor

lgtm get this in :D

@hansl

Copy link
Copy Markdown
Contributor

Oh shoot totally missed that. You should have a separate lint script instead, please.

@Brocco

Copy link
Copy Markdown
Contributor

Definitely get this in, npm test should run tests 😇

@zackarychapple

Copy link
Copy Markdown
ContributorAuthor

Updated to run tests and lint separately per @hansl

@filipesilva

Copy link
Copy Markdown
Contributor

looks good

@hansl

Copy link
Copy Markdown
Contributor

LGTM

@zackarychapple
zackarychapple merged commit 5da51b0 into angular:masterMar 25, 2016
@zackarychapple
zackarychapple deleted the travis-eslint branch March 25, 2016 03:39
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 9, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@zackarychapple@filipesilva@hansl@Brocco