Skip to content

adds server-config option to ng serve - #3661

Closed
kdimatteo wants to merge 2 commits into
angular:masterfrom
kdimatteo:feature/adds-expressJS-setup
Closed

adds server-config option to ng serve#3661
kdimatteo wants to merge 2 commits into
angular:masterfrom
kdimatteo:feature/adds-expressJS-setup

Conversation

@kdimatteo

@kdimatteokdimatteo commented Dec 21, 2016•
edited
Loading

Copy link
Copy Markdown

feat (webpack-dev-server): add cli option for static mocks

Add the option to serve static JSON mocks when discreet server is not necessary or available

@googlebot

googlebot commented Dec 21, 2016

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@kdimatteo

kdimatteo commented Dec 21, 2016

Copy link
Copy Markdown
Author

I signed it!

@googlebot

googlebot commented Dec 21, 2016

Copy link
Copy Markdown

CLAs look good, thanks!

@kdimatteo
kdimatteoforce-pushed the feature/adds-expressJS-setup branch 5 times, most recently from b735a2e to 1f3c46cCompareDecember 21, 2016 15:23
@kdimatteo
kdimatteoforce-pushed the feature/adds-expressJS-setup branch from 1f3c46c to 39b75dbCompareDecember 21, 2016 15:24
victormejia
victormejia reviewed Dec 22, 2016
View reviewed changes
Comment threadREADME.md Outdated
Webpack dev server allows us to modify the ExpressJS `app` object using the `setup` method.
We do this by passing a file to `--server-config`

We create a file next to the projects `package.json` called `server.conf.js` with the content

@victormejiavictormejiaDec 22, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo? project's

victormejia
victormejia reviewed Dec 22, 2016
View reviewed changes
Comment threadtests/e2e/tests/misc/static-server.ts Outdated


export default function() {
// const app = express();

@victormejiavictormejiaDec 22, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete?

@kdimatteokdimatteo mentioned this pull request Feb 2, 2017
Closed
@filipesilva

filipesilva commented Feb 14, 2017

Copy link
Copy Markdown
Contributor

This isn't something we're looking to add. The proxy configuration already let's you do something similar.

@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 11, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 11, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@victormejiavictormejiavictormejia left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kdimatteo@googlebot@filipesilva@victormejia