Uh oh!
There was an error while loading. Please reload this page.
build: Angular2App is now a class, and accepts a set of options for SCSS - #412
Conversation
hansl
commented
Apr 8, 2016
This would allow people to use something different than |
| outFile: outFileName, | ||
| includePaths: [inputPath].concat(this.options.additionalPaths || []) | ||
| }; | ||
There was a problem hiding this comment.
You could do here:
letsassOptions={file: fileName,outFile: outFileName,includePaths: [inputPath].concat(this.options.additionalPaths||[])};sassOptions=Object.assign(sassOptions,this.options);since there are many other options that can be set (examples).
What do you think?
There was a problem hiding this comment.
Done, but removed additionalPaths and copySources.
| return new LESSPlugin([lessSrcTree]); | ||
| return new LESSPlugin([lessSrcTree], options); | ||
| } | ||
| }; |
There was a problem hiding this comment.
You could also add additional options same as you did for sass. And then call it;less.render(content, this.options).
| return new StylusPlugin([stylusSrcTree]); | ||
| return new StylusPlugin([stylusSrcTree], options); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Same as less and then call stylus.render(content, this.options, function(err, css) { ..
Please be careful here, this.options should have filename defined.
86115a3 to
8152724CompareThis issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The majority of the Angular2App changes are moving the code up and changing the reference to
sourceDirto an option.