Uh oh!
There was an error while loading. Please reload this page.
feat(config): ngConfig - #452
Closed
jkuri wants to merge 1 commit into
Closed
Conversation
| config.set(rawArgs[0], rawArgs[1], commandOptions.force); | ||
| let config = new Config(); | ||
| config.validatePath(rawArgs[0]); | ||
| config.set(config.config, rawArgs[0], rawArgs[1]); |
Contributor
There was a problem hiding this comment.
Could you do a a=b kinda of syntax?
Basically:
for(letargofrawArgs){let[key,value]=arg.split('=',1);config.validatePath(key);config.set(key,value);}What do you think? This way we can ng config set key[1]=value1 key[2]=value2.
hansl
commented
Apr 19, 2016
Contributor
Linting and some tests are failing. |
jkuriforce-pushed
the
ng-config
branch
2 times, most recently
from
April 20, 2016 13:13
0c3e9bb to
8aa10efCompareBrocco
commented
Apr 21, 2016
Contributor
jkuri
commented
Apr 21, 2016
ContributorAuthor
@Brocco thanks, I would missed that. |
clydin pushed a commit
that referenced
this pull request
Jun 5, 2018
it has a transitive dep on an updated tsickle that picks up a fix in source-map typings
hansl pushed a commit
that referenced
this pull request
Jun 6, 2018
it has a transitive dep on an updated tsickle that picks up a fix in source-map typings
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.