Uh oh!
There was an error while loading. Please reload this page.
Remove direct dependencies to Angular - #5118
Merged
Merged
Conversation
hanslforce-pushed
the
some-fixes
branch
5 times, most recently
from
March 1, 2017 19:26
c7dbc71 to
f7cdde9Comparehanslforce-pushed
the
some-fixes
branch
4 times, most recently
from
March 17, 2017 23:28
d9772d4 to
119d21fCompareManually check for version now.
So we dont install the wrong version. Instead we rely on the project itself.
It needs to be in the file itself where the require/import is made.
filipesilva
approved these changes
Mar 20, 2017
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So we don't install them in the global install, and we also rely on the ones in the project. They cannot be peerDeps because of global installation, and they cannot be direct dependencies because projects might install 4 while the CLI has 2.4 in its own node_modules, which causes conflicts.
Fixes#5085