Skip to content

chore: remove unnecessary default code - #526

Merged
filipesilva merged 1 commit into
angular:masterfrom
Brocco:remove-placeholder-code
Apr 30, 2016
Merged

chore: remove unnecessary default code#526
filipesilva merged 1 commit into
angular:masterfrom
Brocco:remove-placeholder-code

Conversation

@Brocco

Copy link
Copy Markdown
Contributor

Fixes#516

@hansl

Copy link
Copy Markdown
Contributor

Could you rebase this on top of 565 when it goes in? I've removed 1-2 things but yours need to go in as well. Great work!

@@ -1,3 +1,3 @@
<p>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the <h1> :(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad!!!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be center

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make it <marquee>

@Brocco
Broccoforce-pushed the remove-placeholder-code branch from c42350f to 1e54b69CompareApril 30, 2016 01:20
@filipesilva
filipesilva merged commit 1940d96 into angular:masterApr 30, 2016
@Brocco
Brocco deleted the remove-placeholder-code branch April 30, 2016 01:50
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 9, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove code from app component

4 participants

@Brocco@hansl@jkuri@filipesilva