fix(@ngtools/webpack): allow # in paths - #9236
Merged
Merged
Conversation
clydin
reviewed
Jan 16, 2018
| return undefined; | ||
| } | ||
| const splitted = this._entryModule.split('#'); | ||
| const splitted = this._entryModule.split(/(#[a-zA-Z]+)$/); |
Member
There was a problem hiding this comment.
Names can start with an underscore or letter; and then can contain an underscore, letter, or number.
dinerotah
force-pushed
the
fix-9100
branch
2 times, most recently
from
January 17, 2018 10:29
f6b6b7d to
aac36de
Compare
filipesilva
approved these changes
Jan 17, 2018
Contributor
|
LGTM, thanks! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #9100
Fix #8141
Fix #7071