Uh oh!
There was an error while loading. Please reload this page.
docs(dart): update BASICS intro - #1410
Conversation
kwalrath
commented
May 16, 2016
@wardbell do you want me to make the section descriptions match what's really there? |
wardbell
commented
May 17, 2016
@kwalrath Please do :-) |
| A running version of that sample is at | ||
| https://angular-examples.github.io/architecture/. | ||
| A few early chapters are written as tutorials and are clearly marked as such. |
There was a problem hiding this comment.
Why not include this paragraph (L15-18) in the TS version?
There was a problem hiding this comment.
It's the "live link" vs. "sample repo" difference. I could've made it a variable and probably should.
There was a problem hiding this comment.
Ah, right. I just feel that we should minimize differences between the language versions. The added remark will be useful to TS and JS users too :). If you don't want to define a variable, you could just drop the last sentence (L18) and put L15-17 in the TS version. It's up to you.
There was a problem hiding this comment.
It actually is in the TS & JS pages, but they have an all-plunkr solution where they can change the example. So the text needs to be different.
chalin
commented
May 17, 2016
Other than the one inlined comment made about moving a paragraph to the TS version, it LGTM. |
Also copy edited the TS version a bit. NOTE: The TS version (and thus the Dart version) talks about "Reference" and "Resources" sections that don't exist. (API Reference does, but not Reference, as such.)
kwalrath
commented
May 18, 2016
About to merge... |
Also copy edited the TS version a bit.
NOTE: The TS version (and thus the Dart version) talks about "Reference" and "Resources" sections that don't exist. (API Reference does, but not Reference, as such.)