Uh oh!
There was an error while loading. Please reload this page.
chore(docs): revise makeExcerpt mixin for DRYer ref to examples - #1420
Conversation
LGTM. @wardbell do you have an opinion? I wonder if the name makeExample1 could be clearer. makeExample2? makeSimpleExample? |
Foxandxss
commented
May 17, 2016
Or perhaps |
wardbell
commented
May 18, 2016
I like but the name has to change. Happy to accept after that change. |
chalin
commented
May 18, 2016
I agree about the name, but figured I run by the basic idea first. I originally thought of: |
Be more DRY when referencing examples and excerpts. E.g.,
```jade
+makeExcerpt('quickstart/ts/app/app.component.ts', 'import',
'app/app.component.ts (import)')
```
can now be just
```jade
+makeExcerpt('app/app.component.ts', 'import')
```
Defined new mixin for examples named `makeExample1` using this new
scheme.
The original `makeExample` has been left untouched.
Applied new mixins to quickstart.6be9c40 to
9abec7cComparechalin
commented
May 18, 2016
kwalrath
commented
May 18, 2016
OK, I'll merge a little later this morning. Thanks, Patrice! |
Avoiding
tsin the file path will make it a bit easier to construct the path to the Dart version (by simply appending to the path rather than having to massage the path).This update allows us to be more DRY when referencing examples and excerpts. E.g.,
can now be just
With the resulting examples and their titles being rendered the same as before. The original
makeExamplehas been left untouched.Applied new mixins to quickstart.