Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(guide/displaying-data): proofread - #1819
Merged
Merged
Conversation
chalin
commented
Jul 4, 2016
ContributorAuthor
@Foxandxss@wardbell@kwalrath : ready for review. As usual, it is best viewed by ignoring whitespace diffs. |
Foxandxss
commented
Jul 4, 2016
Member
TS part works for me. |
chalinforce-pushed
the
chalin-guide-disp-data-0702
branch
from
July 4, 2016 21:16
d653f20 to
13e7e07Compare| * declares a constructor parameter and its type | ||
| * declares a public property of the same name | ||
| * initializes that property with the corresponding argument when we "new" an instance of the class | ||
| +makeExcerpt('app/hero.ts ()', 'id') |
ContributorAuthor
There was a problem hiding this comment.
Because of the () the mixin will render the title as app/hero.ts (excerpt).
chalinforce-pushed
the
chalin-guide-disp-data-0702
branch
from
July 6, 2016 11:37
13e7e07 to
db70c41Compare| * [Showing !{_an} !{_array} property with NgFor](#ngFor) | ||
| * [Conditional display with NgIf](#ngIf) | ||
| <li if-docs="ts">only ts</li> |
Contributor
There was a problem hiding this comment.
Why is this line here? This shows up as a weird "only ts" bullet item in the TS version of the docs...
ContributorAuthor
There was a problem hiding this comment.
That was just for a test. It should not have been left in (no sure how it slipped by). Thanks for catching it!
Fixed.
kwalrath
commented
Jul 7, 2016
Contributor
I did a side-by-side comparison, and apart from the couple of minor things I commented on, LGTM. |
chalinforce-pushed
the
chalin-guide-disp-data-0702
branch
from
July 7, 2016 19:26
db70c41 to
13fe33fComparechalin
commented
Jul 7, 2016
ContributorAuthor
Fixed and committed. |
- Dart prose simplified by removing discussion of "additions to pubspec.yaml" which are no longer necessary given the current state of QuickStart. - E2e suites passed: public/docs/_examples/displaying-data/dart public/docs/_examples/displaying-data/ts Contributes to angular#1598 and angular#1508.
- TS prose updated to include @kwalrath's revisions from a while ago, with some of my edits as well. - E2e suites passed: public/docs/_examples/displaying-data/dart public/docs/_examples/displaying-data/ts
chalinforce-pushed
the
chalin-guide-disp-data-0702
branch
from
July 7, 2016 19:30
13fe33f to
1fb1df4Comparekwalrath
commented
Jul 7, 2016
Contributor
LGTM |
This was referenced Jul 7, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pubspec.yaml" which are no longer necessary given the current state of QuickStart.Contributes to #1598 and #1508.
Depends on #1818.