Uh oh!
There was an error while loading. Please reload this page.
docs(glossary): general cleanup and fix links - #2100
Conversation
@kwalrath@wardbell@Foxandxss : Ready for review. Best viewed by ignoring whitespace.
|
7f0a6bd to
c045020Compare| `bootstrap` method. The `bootstrap` method identifies an | ||
| application's top level "root" [Component](#component) and optionally | ||
| registers service [providers](#provider) with the [dependency injection | ||
| system](#dependency-injection). |
There was a problem hiding this comment.
For some reason I was under the impression that the old definition was appearing in the JS glossary, but you are correct, it should not. I'll remove it and rebase.
Foxandxss
commented
Aug 17, 2016
This needs rebase, but I like what I see. |
c045020 to
bdd018cCompare| block annotation-defn | ||
| :marked | ||
| There are different kinds of annotation in Dart. Unqualified use of the |
There was a problem hiding this comment.
Let's reword the first two sentences to remove the "There are" and give a hint as to what other uses of "annotation" might be. (The first sentence stopped me cold, as I tried to recall what the other kinds of annotations were.) Maybe:
When unqualified, _annotation_ refers to a Dart [metadata annotation][metadata] (as opposed to, say, a type annotation).
kwalrath
commented
Aug 17, 2016
Aside from what I marked, LGTM. |
This commit addresses issues with the glossary for all languages (JS, TS, Dart). Fixesangular#1123, angular#1838, angular#2036. This was originally started as post-RC5 Dart resync, but since mixing Harp partials with Jade mixins can be problematic, this commit does a general cleanup of the 3 x 2 = 6 glossary files (found in `{ts,js,dart}/latest/{.,guide}`). This commit builds upon angular#2098 (which created the first `ts/_cache` copy of the glossary), but doesn't really depend on it.
bdd018c to
de8fb3fCompareBlocked by @kwalrath until current glossary review is done |
Actually, I wanted this change in before the editor looks at it. Pushing the updated site now... |
This commit addresses issues with the glossary for all languages (JS, TS, Dart).
Fixes#1123, #1838, #2036.
Contributes to #1508.
This was originally started as post-RC5 Dart resync, but since mixing Harp partials with Jade mixins can be problematic, this commit does a general cleanup of the 3 x 2 = 6 glossary files (found in
{ts,js,dart}/latest/{.,guide}).This commit builds upon #2098 (which created the first
ts/_cachecopy of the glossary), but doesn't really depend on it.