Uh oh!
There was an error while loading. Please reload this page.
chore: convert relative templateUrl/styleUrls to have ./ - #3071
Conversation
b652ef5 to
4ec1736Comparegooglebot
commented
Jan 4, 2017
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
1 similar comment
googlebot
commented
Jan 4, 2017
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
wardbell
commented
Jan 4, 2017
Thank you! I dug into Style Guide which was hiding the Fixed that. Started adding/correcting advice, and soon had a lot of Style Guide "improvements". I'll merge these with yours ... they overlap so much ... but keep the commits separate. |
/cc @Foxandxss@wardbell
See my comment below about piggy-backing with improvements to Style Guide.